public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	Luis Machado <luis.machado@linaro.org>
Subject: [review] Remove the "next" field from windows_thread_info
Date: Tue, 12 Nov 2019 19:42:00 -0000	[thread overview]
Message-ID: <20191112194240.CCD2A20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572371871000.Ib93c54e529a5d82515883f44a478eeb0ff0dbae9@gnutoolchain-gerrit.osci.io>

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/404
......................................................................


Patch Set 1:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +2,19 @@ Parent:     12c3e917 (Automatic date update in version.in)
| +Author:     Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-10-07 13:45:15 -0600
| +Commit:     Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-10-29 10:08:34 -0600
| +
| +Remove the "next" field from windows_thread_info
| +
| +This changes windows_thread_info to remove the "next" field, replacing
| +the linked list of threads with a vector.  This is a prerequisite to
| +sharing is structure with gdbserver, which manages threads

PS1, Line 11:

> "this"?

Yep, thanks.  I've fixed this.  I'm going to push this
and the other patches from this series that have been
reviewed.

| +differently.
| +
| +gdb/ChangeLog
| +2019-10-29  Tom Tromey  <tromey@adacore.com>
| +
| +	* windows-nat.c (struct windows_thread_info): Remove typedef.
| +	(thread_head): Remove.
| +	(thread_list): New global.
| +	(thread_rec, windows_add_thread, windows_init_thread_list)

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib93c54e529a5d82515883f44a478eeb0ff0dbae9
Gerrit-Change-Number: 404
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Tue, 12 Nov 2019 19:42:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment

  parent reply	other threads:[~2019-11-12 19:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 17:57 Tom Tromey (Code Review)
2019-10-31  3:18 ` Luis Machado (Code Review)
2019-10-31 14:20 ` Simon Marchi (Code Review)
2019-11-12 19:42 ` Tom Tromey (Code Review) [this message]
2019-11-12 19:58 ` Tom Tromey (Code Review)
2019-11-26 17:11 ` [review v2] " Tom Tromey (Code Review)
2019-11-29 17:47 ` Pedro Alves (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112194240.CCD2A20AF6@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=gnutoolchain-gerrit@osci.io \
    --cc=luis.machado@linaro.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).