From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79177 invoked by alias); 12 Nov 2019 19:42:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79168 invoked by uid 89); 12 Nov 2019 19:42:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=luis, Luis, Automatic, luis.machado@linaro.org X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2019 19:42:45 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B431E20C7E; Tue, 12 Nov 2019 14:42:43 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id F122220308; Tue, 12 Nov 2019 14:42:40 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id CCD2A20AF6; Tue, 12 Nov 2019 14:42:40 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 12 Nov 2019 19:42:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove the "next" field from windows_thread_info X-Gerrit-Change-Id: Ib93c54e529a5d82515883f44a478eeb0ff0dbae9 X-Gerrit-Change-Number: 404 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2124a58ad3922c9a95c93e4be61ee18bc288cb2b In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 12 Nov 2019 14:42:40 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191112194240.CCD2A20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00335.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/404 ...................................................................... Patch Set 1: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +2,19 @@ Parent: 12c3e917 (Automatic date update in version.in) | +Author: Tom Tromey | +AuthorDate: 2019-10-07 13:45:15 -0600 | +Commit: Tom Tromey | +CommitDate: 2019-10-29 10:08:34 -0600 | + | +Remove the "next" field from windows_thread_info | + | +This changes windows_thread_info to remove the "next" field, replacing | +the linked list of threads with a vector. This is a prerequisite to | +sharing is structure with gdbserver, which manages threads PS1, Line 11: > "this"? Yep, thanks. I've fixed this. I'm going to push this and the other patches from this series that have been reviewed. | +differently. | + | +gdb/ChangeLog | +2019-10-29 Tom Tromey | + | + * windows-nat.c (struct windows_thread_info): Remove typedef. | + (thread_head): Remove. | + (thread_list): New global. | + (thread_rec, windows_add_thread, windows_init_thread_list) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ib93c54e529a5d82515883f44a478eeb0ff0dbae9 Gerrit-Change-Number: 404 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Simon Marchi Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 12 Nov 2019 19:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment