[review v2] Introduce new layout code

["Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/367
......................................................................


Patch Set 2:

(2 comments)

I started looking through and had a few comments.  I still need to finish looking through the layout code though, but I hope to get back to this soon.

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +2,19 @@ Parent:     7e625c33 (Remove struct tui_point)
| +Author:     Tom Tromey <tom@tromey.com>
| +AuthorDate: 2019-10-07 18:03:02 -0600
| +Commit:     Tom Tromey <tom@tromey.com>
| +CommitDate: 2019-11-06 06:23:34 -0700
| +
| +Introduce new layout code
| +
| +This introduces a new approach to window layout for the TUI.  The idea
| +behind this code is that a layout should be specified in a declarative
| +way, and the applied by generic code that does not need to know the

PS2, Line 11:

typo: ...and THEN applied...

| +specifics of every possible layout.
| +
| +This patch itself does not change any behavior, because the new layout
| +engine isn't yet connected to anything.  That is, this merely
| +introduces the implementation.
| +
| +This generic approach makes the code more maintainable.  It also
| +enables some future changes:
| +
| --- gdb/tui/tui-layout.c
| +++ gdb/tui/tui-layout.c
| @@ -538,8 +538,19 @@ show_source_or_disasm_and_command (enum tui_layout_type layout_type)
|    TUI_CMD_WIN->resize (cmd_height,
|  		       tui_term_width (),
|  		       0,
|  		       src_height);
|  }
|  
|  \f
|  
| +static tui_gen_win_info *
| +tui_get_window_by_name (const std::string &name)

PS2, Line 547:

I noticed that all the new functions are missing header comments.  I
can see that some (all?) of the class functions are documented in the
header file, in this case the GDB style seems to be /* See somefile.h.
*/, right?

| +{
| +  if (name == "src")
| +    {
| +      if (tui_win_list[SRC_WIN] == nullptr)
| +	tui_win_list[SRC_WIN] = new tui_source_window ();
| +      return tui_win_list[SRC_WIN];
| +    }
| +  else if (name == "cmd")
| +    {

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3a4cae666327b617d862aaa356f8179f945c6a4e
Gerrit-Change-Number: 367
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 12:02:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment