From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9414 invoked by alias); 18 Nov 2019 18:58:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9406 invoked by uid 89); 18 Nov 2019 18:58:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.2 required=5.0 tests=BAYES_50,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=prop_const, 978,17, LONGEST, UD:kind X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 18:58:31 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 745E8202D0; Mon, 18 Nov 2019 13:58:30 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 00E9420250; Mon, 18 Nov 2019 13:58:28 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id BD2992816F; Mon, 18 Nov 2019 13:58:28 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 18 Nov 2019 18:58:00 -0000 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb/fortran: array stride support X-Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a X-Gerrit-Change-Number: 627 X-Gerrit-ChangeURL: X-Gerrit-Commit: c9eaa3e9c36d105ed499e65eac5ea7dde36d22d2 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 13:58:28 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118185828.BD2992816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00541.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/627 ...................................................................... Patch Set 1: (1 comment) | --- gdb/gdbtypes.c | +++ gdb/gdbtypes.c | @@ -978,17 +1007,18 @@ create_static_range_type (struct type *result_type, struct type *index_type, | /* Predicate tests whether BOUNDS are static. Returns 1 if all bounds values | are static, otherwise returns 0. */ | | static int | has_static_range (const struct range_bounds *bounds) | { | return (bounds->low.kind == PROP_CONST | - && bounds->high.kind == PROP_CONST); | + && bounds->high.kind == PROP_CONST | + && bounds->stride.kind == PROP_CONST); PS1, Line 1015: Yes, sorry about this -- I missed the hunk that initializes this field in create_range_type. | } | | | /* Set *LOWP and *HIGHP to the lower and upper bounds of discrete type | TYPE. Return 1 if type is a range type, 0 if it is discrete (and | bounds will fit in LONGEST), or -1 otherwise. */ | | int | get_discrete_bounds (struct type *type, LONGEST *lowp, LONGEST *highp) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a Gerrit-Change-Number: 627 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Mon, 18 Nov 2019 18:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Comment-In-Reply-To: Tom Tromey Gerrit-MessageType: comment