From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55068 invoked by alias); 18 Nov 2019 19:36:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55060 invoked by uid 89); 18 Nov 2019 19:36:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1942 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2019 19:36:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4448F20413; Mon, 18 Nov 2019 14:36:20 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 088C42012A; Mon, 18 Nov 2019 14:36:18 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8FF8E2816F; Mon, 18 Nov 2019 14:36:13 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Mon, 18 Nov 2019 19:36:00 -0000 From: "Simon Marchi (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Update Gnulib to the latest git version X-Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa X-Gerrit-Change-Number: 681 X-Gerrit-ChangeURL: X-Gerrit-Commit: 14ad4f5d13b22c6b80a0bcf7fdd7ac17898419e1 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 18 Nov 2019 14:36:12 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191118193613.8FF8E2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00545.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/681 ...................................................................... Patch Set 5: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +13,22 @@ https://lists.gnu.org/archive/html/bug-gnulib/2019-11/msg00024.html | +All of GDB's local Gnulib patches were already fixed upstream per their | +descriptions, so this patch removes them all. | + | +The problem listed here: | +https://sourceware.org/ml/gdb-patches/2019-08/msg00553.html | +was probably partially fixed by moving gnulib to the toplevel; | +however, to fix the remaining issues I had to add a local patch | +to override $(CC) in import/Makefile.am. Here is the rationale: | + | + The toplevel makefile overrides $(CC) (in EXTRA_HOST_FLAGS), which breaks | + in Gnulib with older GCCs, because it uses this variable to store the | + C11 flag (-std=gnu11). Override it here so we always get the value | + from configure. PS5, Line 25: In case somebody wants to reproduce the problem, it would be good to mention that this happens with compilers that don't use c99 by default, like gcc 4.8.5 on Centos 7. | + | +gdb/ChangeLog: | + | +2019-11-17 Christian Biesinger | + | + * gdbsupport/common-defs.h: Remove workaround for a gnulib bug | + (we no longer need to include time.h before pathmax.h) | + | +gnulib/ChangeLog: -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9c2b07a3046baecfb664e21b2644353ea888dbfa Gerrit-Change-Number: 681 Gerrit-PatchSet: 5 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Mon, 18 Nov 2019 19:36:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment