From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: [review] Turn off threaded minsym demangling by default
Date: Tue, 19 Nov 2019 21:54:00 -0000 [thread overview]
Message-ID: <20191119215401.6C9DD2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574132431000.I92ba4f6bbf07363189666327cad452d6b9c8e01d@gnutoolchain-gerrit.osci.io>
Christian Biesinger has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/687
......................................................................
Patch Set 1:
tromey -- sorry I missed your IRC question; here I did more than just change the setting because I was concerned that deferring the symbol_set_names call may have a risk in case some code relies on the name being set earlier. Beyond that I skipped all the threading set up because it's not necessary with that first part. But if you think I'm overly cautious I'm fine with not doing that.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I92ba4f6bbf07363189666327cad452d6b9c8e01d
Gerrit-Change-Number: 687
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Biesinger <cbiesinger@google.com>
Gerrit-Reviewer: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 21:54:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-19 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 3:00 Christian Biesinger (Code Review)
2019-11-19 21:54 ` Christian Biesinger (Code Review) [this message]
2019-11-22 23:48 ` Tom Tromey (Code Review)
2019-11-26 21:53 ` [review v2] " Christian Biesinger (Code Review)
2019-11-26 21:55 ` Tom Tromey (Code Review)
2019-11-27 21:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-27 21:40 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119215401.6C9DD2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).