From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15758 invoked by alias); 21 Nov 2019 13:34:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15750 invoked by uid 89); 21 Nov 2019 13:34:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Nov 2019 13:34:12 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C6F0C203AF; Thu, 21 Nov 2019 08:34:10 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 60BC42020A; Thu, 21 Nov 2019 08:34:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3AB712816F; Thu, 21 Nov 2019 08:34:07 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Thu, 21 Nov 2019 13:34:00 -0000 From: "Tom Tromey (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Joel Brobecker , Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: cede0513116b126cb1ef7506cd1ff25eb86cf878 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 21 Nov 2019 08:34:06 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191121133407.3AB712816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00648.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 3: Code-Review+2 > Patch Set 3: > > > Patch Set 3: > > For me, the current patch is OK for 9.x, as it seems its impact is relatively controlled. > > > > The ignore.patch fix, on the other hand, seems a little too risky for inclusion this late before we branch 9.x. > > Hi Joel, thanks for the comments. Do I understand correctly then that I should commit the current patch to trunk? I re-read the thread and the patch, and I think this is fine to check in. One factor that helped was that I finally realized that this would only cause more searching in the case where a declaration is found, which maybe is not super common. Thank you for doing this. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 Gerrit-Change-Number: 29 Gerrit-PatchSet: 3 Gerrit-Owner: Tom de Vries Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Tom Tromey Gerrit-Reviewer: Tom de Vries Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Thu, 21 Nov 2019 13:34:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment