[review v5] [Debugging output] Make remote packet truncation length adjustable

["Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Pedro Alves has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/691
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

Thanks.  This looks good.

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +23,19 @@ gdb/ChangeLog:
| +2019-11-21  Luis Machado  <luis.machado@linaro.org>
| +
| +	* NEWS (New Commands): Mention "set debug remote-packet-max-chars".
| +	* remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
| +	(remote_packet_max_chars): New static global.
| +	(show_remote_packet_max_chars): New function.
| +	(remote_target::putpkt_binary): Adjust to use new
| +	remote-packet-max-chars option.
| +	(remote_target::getpkt_or_notif_sane_1): Likewise.
| +	(_initialize_remote): Register new remote_packet_max_chars option.

PS5, Line 32:

> (_initialize_remote): Register new remote_packet_max_chars option.

I guess you mean to use hyphens here as well.  This is actually the
case that I was referring to earlier.

| +
| +gdb/doc/ChangeLog:
| +
| +2019-11-21  Luis Machado  <luis.machado@linaro.org>
| +
| +	* gdb.texinfo (Debugging Output): Document set debug
| +	remote-packet-max-chars.
| +
| +Signed-off-by: Luis Machado <luis.machado@linaro.org>
| --- gdb/remote.c
| +++ gdb/remote.c
| @@ -1715,7 +1715,19 @@ static int remote_packet_max_chars = 512;
| +/* Show the maximum number of characters to display for a remote packet when
| +   remote debugging is enabled.  */
| +
| +static void
| +show_remote_packet_max_chars (struct ui_file *file, int from_tty,
| +			      struct cmd_list_element *c,
| +			      const char *value)
| +{
| +  fprintf_filtered (file, _("Remote packet output will be truncated at %s "
| +			    "characters.\n"), value);

PS4, Line 1724:

> "Number of remote packet characters to display is %s.\n"?

That looks good.

| +}
| +
|  long
|  remote_target::get_memory_write_packet_size ()
|  {
|    return get_memory_packet_size (&memory_write_packet_config);
|  }
|  
|  static struct memory_packet_config memory_read_packet_config =

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2e871b37bfcaa6376537c3fe3db8f016dd806a7c
Gerrit-Change-Number: 691
Gerrit-PatchSet: 5
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 22 Nov 2019 15:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Luis Machado <luis.machado@linaro.org>
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment