From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37888 invoked by alias); 22 Nov 2019 17:46:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37875 invoked by uid 89); 22 Nov 2019 17:46:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 17:46:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1FA8220393; Fri, 22 Nov 2019 12:46:37 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id D02772030C; Fri, 22 Nov 2019 12:46:33 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id AC91D2816F; Fri, 22 Nov 2019 12:46:33 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Fri, 22 Nov 2019 17:46:00 -0000 From: "Simon Marchi (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] gdb/fortran: array stride support X-Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a X-Gerrit-Change-Number: 627 X-Gerrit-ChangeURL: X-Gerrit-Commit: 874338c54548ddbcf34c8c1827234ace78e04859 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 12:46:33 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122174633.AC91D2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00728.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/627 ...................................................................... Patch Set 5: (1 comment) | --- gdb/gdbtypes.c | +++ gdb/gdbtypes.c | @@ -2017,0 +2061,19 @@ resolve_dynamic_range (struct type *dyn_range_type, | + { | + stride.kind = PROP_CONST; | + stride.data.const_val = value; | + | + /* If we have a bit stride that is not a multiple of the byte stride | + then I really don't think this is going to work with current GDB. | + The array indexing code in GDB seems to be pretty heavily tied to | + byte offsets right now. If this comes up then we warn the user | + and set up a known incorrect stride. */ | + if (!byte_stride_p && (value % HOST_CHAR_BIT) != 0) PS4, Line 2070: Sorry, I meant gdbarch_addressable_memory_unit_size * 8, to have the number of bits in a "byte" on that architecture. I think TARGET_CHAR_BIT is actually broken and should be removed, because it is a compile time constant. Given that you can debug code from different architectures (some with 8 bit bytes and some with 16 bit bytes) with the same GDB, TARGET_CHAR_BIT will necessarily be wrong for some of these architectures. | + error (_("bit strides that are not a multiple of the byte size " | + "are currently not supported")); | + } | + else | + { | + stride.kind = PROP_UNDEFINED; | + stride.data.const_val = 0; | + byte_stride_p = true; | + } -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9af2bcd1f2d4c56f76f5f3f9f89d8f06bef10d9a Gerrit-Change-Number: 627 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-CC: Tom Tromey Gerrit-Comment-Date: Fri, 22 Nov 2019 17:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment