From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127783 invoked by alias); 22 Nov 2019 23:53:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127773 invoked by uid 89); 22 Nov 2019 23:53:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=7612, 76,12, white X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2019 23:53:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 53D3E2053D; Fri, 22 Nov 2019 18:53:24 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 3B449202EB; Fri, 22 Nov 2019 18:53:23 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 1B9062816F; Fri, 22 Nov 2019 18:53:23 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 22 Nov 2019 23:53:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Allow using less horizontal space in TUI source window X-Gerrit-Change-Id: I46ce9a68b12c9c79332d510f9c14b3c84b7efadd X-Gerrit-Change-Number: 605 X-Gerrit-ChangeURL: X-Gerrit-Commit: 610d817dcc37d1ec3b7aaff4a3f21074fedd07ca In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 22 Nov 2019 18:53:22 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191122235323.1B9062816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00772.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/605 ...................................................................... Patch Set 1: (1 comment) | --- gdb/tui/tui-source.c | +++ gdb/tui/tui-source.c | @@ -76,12 +80,19 @@ tui_source_window::set_contents (struct gdbarch *arch, | cur_line = 0; | gdbarch = get_objfile_arch (SYMTAB_OBJFILE (s)); | start_line_or_addr.loa = LOA_LINE; | cur_line_no = start_line_or_addr.u.line_no = line_no; | | + int digits = 0; | + if (compact_source) | + { | + double l = log10 (offsets->size ()) + 1; | + digits = 1 + (int) l; PS1, Line 89: > If I understand correctly one of the +1's here is for the white space that is displayed on the left of the number when it is being printed (the calculation here always gives number of digits + 1). Actually I just inserted a second +1 for no reason -- it was an error. I've corrected this. | + } | + | const char *iter = srclines.c_str (); | content.resize (nlines); | while (cur_line < nlines) | { | struct tui_source_element *element | = &content[cur_line]; | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I46ce9a68b12c9c79332d510f9c14b3c84b7efadd Gerrit-Change-Number: 605 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Andrew Burgess Gerrit-Comment-Date: Fri, 22 Nov 2019 23:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Andrew Burgess Gerrit-MessageType: comment