From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114667 invoked by alias); 25 Nov 2019 12:58:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114642 invoked by uid 89); 25 Nov 2019 12:58:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=3100, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 12:58:57 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7C01E20387; Mon, 25 Nov 2019 07:58:55 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id E005C2018B for ; Mon, 25 Nov 2019 07:58:53 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A61A020AF6 for ; Mon, 25 Nov 2019 07:58:53 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 25 Nov 2019 12:58:00 -0000 From: "Mihails Strasuns (Code Review)" To: gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 10a8b9ce25779daa2ce018a694b1390017e7eeb4 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 25 Nov 2019 07:58:52 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191125125853.A61A020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00823.txt.bz2 Mihails Strasuns has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 1: (1 comment) | --- gdb/breakpoint.c | +++ gdb/breakpoint.c | @@ -3066,2 +3091,19 @@ int | +forget_breakpoint_locations_obj (objfile *obj) | +{ | + struct bp_location **blp, *bl; | + | + int count = 0; | + | + ALL_BP_LOCATIONS (bl, blp) | + if (bl->symtab != NULL && SYMTAB_OBJFILE (bl->symtab) == obj) | + { | + bool ret = remove_location_from_bp (bl->owner, bl); PS1, Line 3100: There is also an option of reusing existing `shlib_disabled` flag here instead - jit code is not a shared library but underlying logic should be quite similar. I don't fully understand possible side effects of doing so though. | + gdb_assert (ret); | + ++count; | + } | + | + return count; | +} | + | static int internal_breakpoint_number = -1; | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 1 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-Comment-Date: Mon, 25 Nov 2019 12:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment