[review] jit: minor improvement to debug logging

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................


Patch Set 1:

(1 comment)

Hi Mihails,

Thanks for doing this, I just noted a small comment.

| --- gdb/jit.c
| +++ gdb/jit.c
| @@ -953,17 +953,19 @@ jit_register_code (struct gdbarch *gdbarch,
|  }
|  
|  /* This function unregisters JITed code and frees the corresponding
|     objfile.  */
|  
|  static void
|  jit_unregister_code (struct objfile *objfile)
|  {
| +  if (jit_debug)
| +    fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%p)\n", objfile);

PS1, Line 962:

For a reason I can't remember, we don't use %p (because it's not
reliable on some platform?).  Use "%s" with host_address_to_string
instead.

|    delete objfile;
|  }
|  
|  /* Look up the objfile with this code entry address.  */
|  
|  static struct objfile *
|  jit_find_objf_with_entry_addr (CORE_ADDR entry_addr)
|  {
|    for (objfile *objf : current_program_space->objfiles ())

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 1
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 25 Nov 2019 14:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment