From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104964 invoked by alias); 25 Nov 2019 14:40:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104955 invoked by uid 89); 25 Nov 2019 14:40:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1076 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 14:40:06 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 5F7FE202DF; Mon, 25 Nov 2019 09:40:05 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 8563C202D0; Mon, 25 Nov 2019 09:40:03 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 10EA420AF6; Mon, 25 Nov 2019 09:40:03 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Mon, 25 Nov 2019 14:40:00 -0000 From: "Simon Marchi (Code Review)" To: Mihails Strasuns , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 10a8b9ce25779daa2ce018a694b1390017e7eeb4 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 25 Nov 2019 09:40:02 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191125144003.10EA420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00827.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 1: Just trying to understand the problem better. From what I understand, when the breakpoint locations must be updated following a code change event (e.g. solib getting loaded or unloaded), we call breakpoint_re_set, which goes through all breakpoint locations and sees if they must be updated. Have you tryied calling this from jit_unregister_code? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 1 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Mon, 25 Nov 2019 14:40:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment