From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93030 invoked by alias); 26 Nov 2019 17:11:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92949 invoked by uid 89); 26 Nov 2019 17:11:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=2320 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 17:11:46 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DB46D2094D; Tue, 26 Nov 2019 12:11:42 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 1F61D2046F; Tue, 26 Nov 2019 12:11:31 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id F065F28173; Tue, 26 Nov 2019 12:11:30 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Tue, 26 Nov 2019 17:11:00 -0000 From: "Tom Tromey (Code Review)" To: Luis Machado , Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Use new and delete for windows_thread_info X-Gerrit-Change-Id: I2100e91f371b1fa0ae51aabb2a59ae393f789923 X-Gerrit-Change-Number: 408 X-Gerrit-ChangeURL: X-Gerrit-Commit: cd18049c0fdde50649ec3c4ebb540b11273e8c99 In-Reply-To: References: Reply-To: tromey@sourceware.org, simon.marchi@polymtl.ca, luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191126171130.F065F28173@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00878.txt.bz2 Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/408 ...................................................................... Use new and delete for windows_thread_info This adds a constructor, destructor, and member initializers to windows_thread_info, and changes gdb and gdbserver to use new and delete. gdb/ChangeLog 2019-11-26 Tom Tromey * windows-nat.c (windows_add_thread): Use new. (windows_init_thread_list, windows_delete_thread): Use delete. (get_windows_debug_event): Update. * nat/windows-nat.h (struct windows_thread_info): Add constructor, destructor, and initializers. gdb/gdbserver/ChangeLog 2019-11-26 Tom Tromey * win32-low.c (child_add_thread): Use new. (delete_thread_info): Use delete. Change-Id: I2100e91f371b1fa0ae51aabb2a59ae393f789923 --- M gdb/ChangeLog M gdb/gdbserver/ChangeLog M gdb/gdbserver/win32-low.c M gdb/nat/windows-nat.h M gdb/windows-nat.c 5 files changed, 39 insertions(+), 19 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e24159a..07b5cee 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2019-11-26 Tom Tromey + * windows-nat.c (windows_add_thread): Use new. + (windows_init_thread_list, windows_delete_thread): Use delete. + (get_windows_debug_event): Update. + * nat/windows-nat.h (struct windows_thread_info): Add constructor, + destructor, and initializers. + +2019-11-26 Tom Tromey + * windows-nat.c (struct windows_thread_info): Remove. * nat/windows-nat.h: New file. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 8c0c8ba..e376af3 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,10 @@ 2019-11-26 Tom Tromey + * win32-low.c (child_add_thread): Use new. + (delete_thread_info): Use delete. + +2019-11-26 Tom Tromey + * win32-low.h (struct windows_thread_info): Remove. 2019-11-26 Tom Tromey diff --git a/gdb/gdbserver/win32-low.c b/gdb/gdbserver/win32-low.c index 6a081e2..7e3afff 100644 --- a/gdb/gdbserver/win32-low.c +++ b/gdb/gdbserver/win32-low.c @@ -213,10 +213,7 @@ if ((th = thread_rec (ptid, FALSE))) return th; - th = XCNEW (windows_thread_info); - th->tid = tid; - th->h = h; - th->thread_local_base = (CORE_ADDR) (uintptr_t) tlb; + th = new windows_thread_info (tid, h, (CORE_ADDR) (uintptr_t) tlb); add_thread (ptid, th); @@ -234,7 +231,7 @@ remove_thread (thread); CloseHandle (th->h); - free (th); + delete th; } /* Delete a thread from the list of threads. */ diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h index 30fce27..2fe2a2f 100644 --- a/gdb/nat/windows-nat.h +++ b/gdb/nat/windows-nat.h @@ -23,6 +23,20 @@ each thread. */ struct windows_thread_info { + windows_thread_info (DWORD tid_, HANDLE h_, CORE_ADDR tlb) + : tid (tid_), + h (h_), + thread_local_base (tlb) + { + } + + ~windows_thread_info () + { + xfree (name); + } + + DISABLE_COPY_AND_ASSIGN (windows_thread_info); + /* The Win32 thread identifier. */ DWORD tid; @@ -33,26 +47,26 @@ CORE_ADDR thread_local_base; /* Non zero if SuspendThread was called on this thread. */ - int suspended; + int suspended = 0; #ifdef _WIN32_WCE /* The context as retrieved right after suspending the thread. */ - CONTEXT base_context; + CONTEXT base_context {}; #endif /* The context of the thread, including any manipulations. */ - CONTEXT context; + CONTEXT context {}; /* Whether debug registers changed since we last set CONTEXT back to the thread. */ - int debug_registers_changed; + int debug_registers_changed = 0; /* Nonzero if CONTEXT is invalidated and must be re-read from the inferior thread. */ - int reload_context; + int reload_context = 0; /* The name of the thread, allocated by xmalloc. */ - char *name; + char *name = nullptr; }; #endif diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index f6d4010..31039d5 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -429,10 +429,7 @@ if ((th = thread_rec (id, FALSE))) return th; - th = XCNEW (windows_thread_info); - th->tid = id; - th->h = h; - th->thread_local_base = (CORE_ADDR) (uintptr_t) tlb; + th = new windows_thread_info (id, h, (CORE_ADDR) (uintptr_t) tlb); thread_list.push_back (th); /* Add this new thread to the list of threads. @@ -472,7 +469,7 @@ init_thread_list (); for (windows_thread_info *here : thread_list) - xfree (here); + delete here; thread_list.clear (); } @@ -517,8 +514,7 @@ if (iter != thread_list.end ()) { - xfree ((*iter)->name); - xfree (*iter); + delete *iter; thread_list.erase (iter); } } @@ -1501,7 +1497,7 @@ BOOL debug_event; DWORD continue_status, event_code; windows_thread_info *th; - static windows_thread_info dummy_thread_info; + static windows_thread_info dummy_thread_info (0, 0, 0); DWORD thread_id = 0; last_sig = GDB_SIGNAL_0; -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I2100e91f371b1fa0ae51aabb2a59ae393f789923 Gerrit-Change-Number: 408 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Luis Machado Gerrit-Reviewer: Simon Marchi Gerrit-MessageType: newpatchset