From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65098 invoked by alias); 26 Nov 2019 22:08:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65090 invoked by uid 89); 26 Nov 2019 22:08:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 22:08:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 41B7A203C1; Tue, 26 Nov 2019 17:08:37 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 151D32030C; Tue, 26 Nov 2019 17:08:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id ECE0520AF6; Tue, 26 Nov 2019 17:08:35 -0500 (EST) X-Gerrit-PatchSet: 4 Date: Tue, 26 Nov 2019 22:08:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v4] Precompute hash value for symbol_set_names X-Gerrit-Change-Id: I044449e7eb60cffc1c43efd3412f2b485bd9faac X-Gerrit-Change-Number: 307 X-Gerrit-ChangeURL: X-Gerrit-Commit: 483a455946fa3d08098e26871f65c982ce3df532 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 26 Nov 2019 17:08:35 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191126220835.ECE0520AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg00966.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/307 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thanks for doing this. This looks good to me. I have one nit; this is ok with that fixed. | --- gdb/minsyms.c | +++ gdb/minsyms.c | @@ -1252,13 +1252,19 @@ static void | clear_minimal_symbol_hash_tables (struct objfile *objfile) | { | for (size_t i = 0; i < MINIMAL_SYMBOL_HASH_SIZE; i++) | { | objfile->per_bfd->msymbol_hash[i] = 0; | objfile->per_bfd->msymbol_demangled_hash[i] = 0; | } | } | | +struct computed_hash_values PS4, Line 1261: This should have a comment explaining its purpose. Also the fields should have comments. | +{ | + size_t name_length; | + hashval_t mangled_name_hash; | +}; | + | /* Build (or rebuild) the minimal symbol hash tables. This is necessary | after compacting or sorting the table since the entries move around | thus causing the internal minimal_symbol pointers to become jumbled. */ | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I044449e7eb60cffc1c43efd3412f2b485bd9faac Gerrit-Change-Number: 307 Gerrit-PatchSet: 4 Gerrit-Owner: Christian Biesinger Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Tue, 26 Nov 2019 22:08:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment