From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review v4] Introduce new layout code
Date: Tue, 26 Nov 2019 23:51:00 -0000 [thread overview]
Message-ID: <20191126235057.2320020AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572212661000.I3a4cae666327b617d862aaa356f8179f945c6a4e@gnutoolchain-gerrit.osci.io>
Andrew Burgess has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/367
......................................................................
Patch Set 4: Code-Review+2
LGTM then.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I3a4cae666327b617d862aaa356f8179f945c6a4e
Gerrit-Change-Number: 367
Gerrit-PatchSet: 4
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Tue, 26 Nov 2019 23:50:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-26 23:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 21:44 [review] " Tom Tromey (Code Review)
2019-11-06 14:36 ` [review v2] " Tom Tromey (Code Review)
2019-11-14 12:02 ` Andrew Burgess (Code Review)
2019-11-14 22:51 ` [review v3] " Tom Tromey (Code Review)
2019-11-17 21:59 ` Tom Tromey (Code Review)
2019-11-18 18:25 ` Andrew Burgess (Code Review)
2019-11-19 20:36 ` [review v4] " Tom Tromey (Code Review)
2019-11-23 0:49 ` Andrew Burgess (Code Review)
2019-11-24 18:37 ` Tom Tromey (Code Review)
2019-11-26 23:51 ` Andrew Burgess (Code Review) [this message]
2019-12-11 23:21 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-11 23:21 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126235057.2320020AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).