public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Andrew Burgess (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review v2] Add TUI border colors
Date: Wed, 27 Nov 2019 00:13:00 -0000	[thread overview]
Message-ID: <20191127001344.292FC20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573404038000.Id13e2af0af2a0bde61282752f2c379db3220c9fc@gnutoolchain-gerrit.osci.io>

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/606
......................................................................


Patch Set 2:

I spotted some weird behaviour:

  - Start up a test program,
  - 'tui enable'
  - 'layout next'
  - 'layout next'

At this point you should be in SRC/ASM/CMD layout with the ASM window focused, and its border coloured on just three sides, left, right, and bottom.

  - Scroll the view up (up arrow key), and the top border suddenly becomes coloured.

This seems a little odd!  Now,

  - 'focus prev'

You should still be in SRC/ASM/CMD layout, now with the source window focused, and its border coloured on all four sides.

  - Scroll up (press the up arrow key), you should see the bottom border loose its colour.

This seems odd.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id13e2af0af2a0bde61282752f2c379db3220c9fc
Gerrit-Change-Number: 606
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 00:13:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

  parent reply	other threads:[~2019-11-27  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10 16:40 [review] " Tom Tromey (Code Review)
2019-11-14  9:59 ` Eli Zaretskii
2019-11-22 23:54 ` [review v2] " Tom Tromey (Code Review)
2019-11-23  7:24   ` Eli Zaretskii
2019-12-01 18:55     ` Tom Tromey
2019-11-27  0:13 ` Andrew Burgess (Code Review) [this message]
2019-12-01 18:59   ` Tom Tromey
2019-12-01 19:04 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-01 19:04 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127001344.292FC20AF6@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=gdb-patches@sourceware.org \
    --cc=gnutoolchain-gerrit@osci.io \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).