From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91812 invoked by alias); 27 Nov 2019 00:13:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91798 invoked by uid 89); 27 Nov 2019 00:13:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=press, loose, HContent-Transfer-Encoding:8bit, border X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 00:13:47 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 8D389202D0; Tue, 26 Nov 2019 19:13:45 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 744E4201F1; Tue, 26 Nov 2019 19:13:44 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 292FC20AF6; Tue, 26 Nov 2019 19:13:44 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 27 Nov 2019 00:13:00 -0000 From: "Andrew Burgess (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Add TUI border colors X-Gerrit-Change-Id: Id13e2af0af2a0bde61282752f2c379db3220c9fc X-Gerrit-Change-Number: 606 X-Gerrit-ChangeURL: X-Gerrit-Commit: e59bd76dcd4fe7523826e22802c3ce28d2d8b13d In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 26 Nov 2019 19:13:43 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127001344.292FC20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01002.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/606 ...................................................................... Patch Set 2: I spotted some weird behaviour: - Start up a test program, - 'tui enable' - 'layout next' - 'layout next' At this point you should be in SRC/ASM/CMD layout with the ASM window focused, and its border coloured on just three sides, left, right, and bottom. - Scroll the view up (up arrow key), and the top border suddenly becomes coloured. This seems a little odd! Now, - 'focus prev' You should still be in SRC/ASM/CMD layout, now with the source window focused, and its border coloured on all four sides. - Scroll up (press the up arrow key), you should see the bottom border loose its colour. This seems odd. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id13e2af0af2a0bde61282752f2c379db3220c9fc Gerrit-Change-Number: 606 Gerrit-PatchSet: 2 Gerrit-Owner: Tom Tromey Gerrit-CC: Andrew Burgess Gerrit-Comment-Date: Wed, 27 Nov 2019 00:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment