From: "Luis Machado (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Subject: [review] Avoid infinite recursion in find_pc_sect_line
Date: Wed, 27 Nov 2019 02:19:00 -0000 [thread overview]
Message-ID: <20191127021931.C492220AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574019611000.I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa@gnutoolchain-gerrit.osci.io>
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/682
......................................................................
Patch Set 1:
Out of curiosity, is the example backtrace from a code using the patched version of GDB? How did we break out of the recursion and into lookup_minimal_symbol_by_pc_section?
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I595470be6ab5f61ca7e4e9e70c61a252c0deaeaa
Gerrit-Change-Number: 682
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Buettner <kevinb@redhat.com>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-Comment-Date: Wed, 27 Nov 2019 02:19:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-27 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 19:40 Kevin Buettner (Code Review)
2019-11-27 2:19 ` Luis Machado (Code Review) [this message]
2019-11-27 20:13 ` Kevin Buettner (Code Review)
2019-11-27 23:00 ` Simon Marchi (Code Review)
2019-12-04 22:04 ` Kevin Buettner (Code Review)
2020-03-12 5:59 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2020-03-12 5:59 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127021931.C492220AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).