From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15689 invoked by alias); 27 Nov 2019 12:59:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15681 invoked by uid 89); 27 Nov 2019 12:59:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=dedicated X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 12:59:05 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D766B203AE; Wed, 27 Nov 2019 07:59:03 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 7E2E02018B; Wed, 27 Nov 2019 07:58:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5C8AB20AF6; Wed, 27 Nov 2019 07:58:58 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 27 Nov 2019 12:59:00 -0000 From: "Mihails Strasuns (Code Review)" To: gdb-patches@sourceware.org Cc: Luis Machado , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 232c479ef55b074173b1547b2072916bba6904c2 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 07:58:57 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127125858.5C8AB20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01028.txt.bz2 Mihails Strasuns has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 2: > Should it do so then? I'm not too familiar with the whole jit scheme in GDB, but it sounds like the breakpoint locations should go away when we free the objfile? See my response to Simon above - I was hoping that someone who knows it more can chime in and clarify this bit. The current behavior looks wrong indeed but I am hesitant to change generic objfile behavior without any confirmation from someone who knows this better. The fact that there is currently a dedicated flag for a similar shared library case makes me suspect it may be intentional (otherwise it could just use generic objfile behavior). The `breakpoint_free_objfile` was introduced in 2f202fde0a4586f88b98439b436e7b0bb1336b26 long time ago and I don't see any rationale mentioned there. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 2 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-CC: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 12:58:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment