From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 1/2] Fix BZ 25065 - Ensure that physnames are computed for inherited DIEs
Date: Wed, 27 Nov 2019 20:17:00 -0000 [thread overview]
Message-ID: <20191127131749.1e9c8249@f31-4.lan> (raw)
In-Reply-To: <5cd863fe-979c-3913-13ff-0ed516eae622@polymtl.ca>
On Mon, 4 Nov 2019 15:49:21 -0500
Simon Marchi <simon.marchi@polymtl.ca> wrote:
> > I think that this patch is safer than the one I originally proposed
> > and is, therefore, a better short term solution.
> >
> > What do you think?
>
> Yep, this looks good and relatively safe to me.
>
> Thanks!
I've (finally) pushed this patch along with the test case.
Thanks again for the review.
Kevin
next prev parent reply other threads:[~2019-11-27 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 0:19 [PATCH 0/2] Fix BZ 25065 (LTO related GDB segfault) Kevin Buettner
2019-10-14 0:19 ` [PATCH 1/2] Fix BZ 25065 - Ensure that physnames are computed for inherited DIEs Kevin Buettner
2019-10-14 3:02 ` Simon Marchi
2019-10-15 16:27 ` Kevin Buettner
2019-10-17 3:54 ` Simon Marchi
2019-10-17 5:30 ` Simon Marchi
2019-10-18 1:08 ` Kevin Buettner
2019-10-18 15:07 ` Simon Marchi
2019-10-21 20:05 ` Keith Seitz
2019-10-22 22:23 ` Kevin Buettner
2019-11-04 20:42 ` Kevin Buettner
2019-11-04 20:49 ` Simon Marchi
2019-11-27 20:17 ` Kevin Buettner [this message]
2019-10-14 0:19 ` [PATCH 2/2] Test case for BZ 25065 Kevin Buettner
2019-12-08 10:29 ` [committed] Fix inter-CU references using intra-CU form in imported-unit Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127131749.1e9c8249@f31-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).