From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21127 invoked by alias); 27 Nov 2019 20:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20831 invoked by uid 89); 27 Nov 2019 20:17:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 20:17:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574885874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zAlsrH/cICxd4Muo/x3gPQoZ6/BEvF0H1eBYhgFJRXI=; b=O4N/BmILS2V2OG+55Fr184/9DkuUVoytTKtoNvBeHMy9B84zuwq4k2nEW6irxkh7SMzkHr PRBNjlS71ntC97CnxqzkFK3JY95Vv1BSPkeAeZ4wyX1YqAuEjArlroV8HqxHIlXMW9LMHZ JnAYS10E2YmxMT2I/oxLpQIBLrX9zEU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-G4ANeeC7PxiAo5juUO1eJA-1; Wed, 27 Nov 2019 15:17:52 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FBFB800D41; Wed, 27 Nov 2019 20:17:51 +0000 (UTC) Received: from f31-4.lan (ovpn-116-54.phx2.redhat.com [10.3.116.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23376608BF; Wed, 27 Nov 2019 20:17:51 +0000 (UTC) Date: Wed, 27 Nov 2019 20:17:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 1/2] Fix BZ 25065 - Ensure that physnames are computed for inherited DIEs Message-ID: <20191127131749.1e9c8249@f31-4.lan> In-Reply-To: <5cd863fe-979c-3913-13ff-0ed516eae622@polymtl.ca> References: <20191014001842.27413-1-kevinb@redhat.com> <20191014001842.27413-2-kevinb@redhat.com> <8c073683bc0b0a8e7918fdfb346cbb03@polymtl.ca> <20191015092743.7037f47c@f29-4.lan> <20191017180851.7db69958@f29-4.lan> <8b301205-e8f6-ead5-0484-eacfb82e5b7a@polymtl.ca> <20191022152307.37dea0d1@f29-4.lan> <5cd863fe-979c-3913-13ff-0ed516eae622@polymtl.ca> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg01059.txt.bz2 On Mon, 4 Nov 2019 15:49:21 -0500 Simon Marchi wrote: > > I think that this patch is safer than the one I originally proposed > > and is, therefore, a better short term solution. > > > > What do you think? > > Yep, this looks good and relatively safe to me. > > Thanks! I've (finally) pushed this patch along with the test case. Thanks again for the review. Kevin