From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120651 invoked by alias); 27 Nov 2019 15:36:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120640 invoked by uid 89); 27 Nov 2019 15:36:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2371 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 15:36:41 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D72B22046F; Wed, 27 Nov 2019 10:36:38 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 531EE201F1; Wed, 27 Nov 2019 10:36:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3B63B20AF6; Wed, 27 Nov 2019 10:36:36 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 15:36:00 -0000 From: "Simon Marchi (Code Review)" To: Luis Machado , gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [ARM, sim] Fix build error and warnings X-Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f X-Gerrit-Change-Number: 726 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2650f4cf5fdcdad48033763425070cfdcec43e7a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 10:36:35 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127153636.3B63B20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01042.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/726 ...................................................................... Patch Set 1: (2 comments) | --- sim/arm/arminit.c | +++ sim/arm/arminit.c | @@ -36,15 +36,19 @@ void ARMul_Abort (ARMul_State * state, ARMword address); | unsigned ARMul_MultTable[32] = | { 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 9, | 10, 10, 11, 11, 12, 12, 13, 13, 14, 14, 15, 15, 16, 16, 16 | }; | ARMword ARMul_ImmedTable[4096]; /* immediate DP LHS values */ | char ARMul_BitList[256]; /* number of bits in a byte table */ | | +/* The PC pipeline value depends on whether ARM | + or Thumb instructions are being executed. */ | +ARMword isize; PS1, Line 45: How does moving this here help? There is a declaration of isize in armemu.h, and isize was defined in armemu.c, so I don't immediately see what's wrong with the existing code. | + | /***************************************************************************\ | * Call this routine once to set up the emulator's tables. * | \***************************************************************************/ | | void | ARMul_EmulateInit (void) | { | unsigned long i, j; | --- sim/arm/wrapper.c | +++ sim/arm/wrapper.c | @@ -126,16 +126,16 @@ }; | | union maverick_acc_regs | { | long double ld; /* Acc registers are 72-bits. */ | }; | | -struct maverick_regs DSPregs[16]; | -union maverick_acc_regs DSPacc[4]; | -ARMword DSPsc; | +extern struct maverick_regs DSPregs[16]; PS1, Line 132: Would it be possible to place these declarations in a header file shared between all files that use these variables? Otherwise, there's always the risk that they get out of sync. | +extern union maverick_acc_regs DSPacc[4]; | +extern ARMword DSPsc; | | static void | init (void) | { | static int done; | | if (!done) -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I21db699d3b61b2de8c44053e47be4387285af28f Gerrit-Change-Number: 726 Gerrit-PatchSet: 1 Gerrit-Owner: Luis Machado Gerrit-Reviewer: Andrew Burgess Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 15:36:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment