[review] Move type_byte_order earlier

["Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/728
......................................................................


Patch Set 1:

(2 comments)

| --- gdb/gdbtypes.c
| +++ gdb/gdbtypes.c
| @@ -3344,12 +3344,30 @@ is_unique_ancestor (struct type *base, struct value *val)
|    int offset = -1;
|  
|    return is_unique_ancestor_worker (base, value_type (val), &offset,
|  				    value_contents_for_printing (val),
|  				    value_embedded_offset (val),
|  				    value_address (val), val) == 1;
|  }
|  
| +/* See gdbtypes.h.  */
| +enum bfd_endian

PS1, Line 3353:

Might as well add a newline between the comment and the return type.

| +type_byte_order (const struct type *type)
| +{
| +  bfd_endian byteorder = gdbarch_byte_order (get_type_arch (type));
| +  if (TYPE_ENDIANITY_NOT_DEFAULT (type))
| +    {
| +      if (byteorder == BFD_ENDIAN_BIG)
| +        return BFD_ENDIAN_LITTLE;
| +      else if (byteorder == BFD_ENDIAN_LITTLE)
| +        return BFD_ENDIAN_BIG;
| +      else
| +        return BFD_ENDIAN_UNKNOWN;

PS1, Line 3364:

Also not related to this patch, but is there really a legitimate case
for this else (byteorder being not _BIG and not _LITTLE)?  Sounds to
me like this should be an assert.

| +    }
| +
| +  return byteorder;
| +}
| +
|  \f
|  /* Overload resolution.  */
|  
|  /* Return the sum of the rank of A with the rank of B.  */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4666431ecbb32ec98918f39f72d22c86b2bc8dde
Gerrit-Change-Number: 728
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 22:05:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment