From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78903 invoked by alias); 27 Nov 2019 22:05:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78805 invoked by uid 89); 27 Nov 2019 22:05:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=legitimate X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 22:05:39 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 03E1F2018B; Wed, 27 Nov 2019 17:05:37 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id CEB5A20362; Wed, 27 Nov 2019 17:05:33 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B092520AF6; Wed, 27 Nov 2019 17:05:33 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 22:05:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Move type_byte_order earlier X-Gerrit-Change-Id: I4666431ecbb32ec98918f39f72d22c86b2bc8dde X-Gerrit-Change-Number: 728 X-Gerrit-ChangeURL: X-Gerrit-Commit: ebcc9659e34dc2a01b25ac423e32902e491fa3cc In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 17:05:33 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127220533.B092520AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01073.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/728 ...................................................................... Patch Set 1: (2 comments) | --- gdb/gdbtypes.c | +++ gdb/gdbtypes.c | @@ -3344,12 +3344,30 @@ is_unique_ancestor (struct type *base, struct value *val) | int offset = -1; | | return is_unique_ancestor_worker (base, value_type (val), &offset, | value_contents_for_printing (val), | value_embedded_offset (val), | value_address (val), val) == 1; | } | | +/* See gdbtypes.h. */ | +enum bfd_endian PS1, Line 3353: Might as well add a newline between the comment and the return type. | +type_byte_order (const struct type *type) | +{ | + bfd_endian byteorder = gdbarch_byte_order (get_type_arch (type)); | + if (TYPE_ENDIANITY_NOT_DEFAULT (type)) | + { | + if (byteorder == BFD_ENDIAN_BIG) | + return BFD_ENDIAN_LITTLE; | + else if (byteorder == BFD_ENDIAN_LITTLE) | + return BFD_ENDIAN_BIG; | + else | + return BFD_ENDIAN_UNKNOWN; PS1, Line 3364: Also not related to this patch, but is there really a legitimate case for this else (byteorder being not _BIG and not _LITTLE)? Sounds to me like this should be an assert. | + } | + | + return byteorder; | +} | + | | /* Overload resolution. */ | | /* Return the sum of the rank of A with the rank of B. */ -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I4666431ecbb32ec98918f39f72d22c86b2bc8dde Gerrit-Change-Number: 728 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 22:05:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment