From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129267 invoked by alias); 27 Nov 2019 22:22:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129255 invoked by uid 89); 27 Nov 2019 22:22:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=petit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Nov 2019 22:22:08 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 489A120387; Wed, 27 Nov 2019 17:22:07 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id F1987201A5; Wed, 27 Nov 2019 17:22:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C27C120AF6; Wed, 27 Nov 2019 17:22:05 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 27 Nov 2019 22:22:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Add bit-field test for scalar_storage_order X-Gerrit-Change-Id: I9e07d1b3e08e7c3384832b68ef286afe1d11479a X-Gerrit-Change-Number: 731 X-Gerrit-ChangeURL: X-Gerrit-Commit: 45fd074a80a5921783d294562ebb3c00e6c5210c In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 27 Nov 2019 17:22:05 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191127222205.C27C120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01076.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/731 ...................................................................... Patch Set 1: Code-Review+2 LGTM. When reading this, I wondered if you could arbitrarily nest structures with big and little endianness. I tested with: #include struct gros { unsigned int a; } __attribute__((scalar_storage_order("big-endian"))); struct petit { struct gros g; unsigned int b; } __attribute__((scalar_storage_order("little-endian"))); struct gros2 { struct petit p; unsigned int c; } __attribute__((scalar_storage_order("big-endian"))); int main() { struct gros2 g2; g2.c = 256; g2.p.b = 257; g2.p.g.a = 258; printf("%d %d %d\n", g2.c, g2.p.b, g2.p.g.a); return 0; } It correctly prints this when you run it: $ /tmp/a.out 256 257 258 But GDB prints: (gdb) p g2 $1 = {p = {g = {a = 258}, b = 16842752}, c = 256} It's not really the point of this patch though. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I9e07d1b3e08e7c3384832b68ef286afe1d11479a Gerrit-Change-Number: 731 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Simon Marchi Gerrit-Comment-Date: Wed, 27 Nov 2019 22:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment