public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
@ 2019-11-18 18:12 Andrew Burgess (Code Review)
  2019-11-19  8:04 ` Metzger, Markus T
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Andrew Burgess (Code Review) @ 2019-11-18 18:12 UTC (permalink / raw)
  To: gdb-patches

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................

gdb/testsuite: Fix minor bug in skip_btrace*tests procs

The two guard functions skip_btrace_tests and skip_btrace_pt_tests
have a minor bug, if the check function fails to compile then surely
we should skip the btrace tests - currently we return 0 to indicate
don't skip.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
	compile.
	(skip_btrace_pt_tests): Likewise.

Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 8 insertions(+), 2 deletions(-)



diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3a4d229..a598b23 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-18  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
+	compile.
+	(skip_btrace_pt_tests): Likewise.
+
 2019-11-14  Tom Tromey  <tromey@adacore.com>
 
 	* gdb.base/gdbvars.exp (test_convenience_variables): Add
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 2d395ef..3662a61 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2942,7 +2942,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -2993,7 +2993,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
Gerrit-Change-Number: 685
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: newchange

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
  2019-11-18 18:12 [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs Andrew Burgess (Code Review)
@ 2019-11-19  8:04 ` Metzger, Markus T
  2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Metzger, Markus T @ 2019-11-19  8:04 UTC (permalink / raw)
  To: andrew.burgess, gdb-patches

Hello Andrew,

> gdb/testsuite: Fix minor bug in skip_btrace*tests procs
> 
> The two guard functions skip_btrace_tests and skip_btrace_pt_tests have a minor
> bug, if the check function fails to compile then surely we should skip the btrace tests
> - currently we return 0 to indicate don't skip.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
> 	compile.
> 	(skip_btrace_pt_tests): Likewise.
> 
> Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
> ---
> M gdb/testsuite/ChangeLog
> M gdb/testsuite/lib/gdb.exp
> 2 files changed, 8 insertions(+), 2 deletions(-)

LGTM.

Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [pushed] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
  2019-11-18 18:12 [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs Andrew Burgess (Code Review)
  2019-11-19  8:04 ` Metzger, Markus T
@ 2019-11-28  0:44 ` Sourceware to Gerrit sync (Code Review)
  2019-11-28  0:44 ` [review] " Andrew Burgess (Code Review)
  2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
  3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-28  0:44 UTC (permalink / raw)
  To: Andrew Burgess, gdb-patches

The original change was created by Andrew Burgess.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................

gdb/testsuite: Fix minor bug in skip_btrace*tests procs

The two guard functions skip_btrace_tests and skip_btrace_pt_tests
have a minor bug, if the check function fails to compile then surely
we should skip the btrace tests - currently we return 0 to indicate
don't skip.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
	compile.
	(skip_btrace_pt_tests): Likewise.

Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 8 insertions(+), 2 deletions(-)



diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 86f2130..6b520e1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-28  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
+	compile.
+	(skip_btrace_pt_tests): Likewise.
+
 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* gdb.fortran/info-modules.exp: Compile source files in correct
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 828c91d..4682f5d 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2942,7 +2942,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -2993,7 +2993,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
Gerrit-Change-Number: 685
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: newpatchset

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [pushed] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
  2019-11-18 18:12 [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs Andrew Burgess (Code Review)
                   ` (2 preceding siblings ...)
  2019-11-28  0:44 ` [review] " Andrew Burgess (Code Review)
@ 2019-11-28  0:44 ` Sourceware to Gerrit sync (Code Review)
  3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-28  0:44 UTC (permalink / raw)
  To: Andrew Burgess, gdb-patches

Sourceware to Gerrit sync has submitted this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................

gdb/testsuite: Fix minor bug in skip_btrace*tests procs

The two guard functions skip_btrace_tests and skip_btrace_pt_tests
have a minor bug, if the check function fails to compile then surely
we should skip the btrace tests - currently we return 0 to indicate
don't skip.

gdb/testsuite/ChangeLog:

	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
	compile.
	(skip_btrace_pt_tests): Likewise.

Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/lib/gdb.exp
2 files changed, 8 insertions(+), 2 deletions(-)


diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 86f2130..6b520e1 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-28  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* lib/gdb.exp (skip_btrace_tests): Return 1 if the test fails to
+	compile.
+	(skip_btrace_pt_tests): Likewise.
+
 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 
 	* gdb.fortran/info-modules.exp: Compile source files in correct
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 828c91d..4682f5d 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2942,7 +2942,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -2993,7 +2993,7 @@
     # Compile a test program.
     set src { int main() { return 0; } }
     if {![gdb_simple_compile $me $src executable]} {
-        return 0
+        return 1
     }
 
     # No error message, compilation succeeded so now run it via gdb.

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
Gerrit-Change-Number: 685
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-MessageType: merged

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs
  2019-11-18 18:12 [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs Andrew Burgess (Code Review)
  2019-11-19  8:04 ` Metzger, Markus T
  2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-28  0:44 ` Andrew Burgess (Code Review)
  2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
  3 siblings, 0 replies; 5+ messages in thread
From: Andrew Burgess (Code Review) @ 2019-11-28  0:44 UTC (permalink / raw)
  To: gdb-patches

Andrew Burgess has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/685
......................................................................


Patch Set 1:

I went ahead and merged this fix as obvious.


-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6dfc04b4adcf5b9424fb542ece7ddbe751bee301
Gerrit-Change-Number: 685
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Reviewer: Andrew Burgess <andrew.burgess@embecosm.com>
Gerrit-Comment-Date: Thu, 28 Nov 2019 00:44:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-28  0:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 18:12 [review] gdb/testsuite: Fix minor bug in skip_btrace*tests procs Andrew Burgess (Code Review)
2019-11-19  8:04 ` Metzger, Markus T
2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-28  0:44 ` [review] " Andrew Burgess (Code Review)
2019-11-28  0:44 ` [pushed] " Sourceware to Gerrit sync (Code Review)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).