From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67991 invoked by alias); 28 Nov 2019 05:10:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67974 invoked by uid 89); 28 Nov 2019 05:10:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=jited X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2019 05:10:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A0792203C1; Thu, 28 Nov 2019 00:09:59 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id BF00D201A5; Thu, 28 Nov 2019 00:09:57 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 411E120AF6; Thu, 28 Nov 2019 00:09:54 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Thu, 28 Nov 2019 05:10:00 -0000 From: "Simon Marchi (Code Review)" To: Mihails Strasuns , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 232c479ef55b074173b1547b2072916bba6904c2 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 28 Nov 2019 00:09:53 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191128050954.411E120AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01090.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 2: > See my response to Simon above - I was hoping that someone who knows it more can chime in and clarify this bit. The current behavior looks wrong indeed but I am hesitant to change generic objfile behavior without any confirmation from someone who knows this better. > > The fact that there is currently a dedicated flag for a similar shared library case makes me suspect it may be intentional (otherwise it could just use generic objfile behavior). > > The `breakpoint_free_objfile` was introduced in 2f202fde0a4586f88b98439b436e7b0bb1336b26 long time ago and I don't see any rationale mentioned there. It would really help to have a reproducer that runs on standard x86-64, so we can play with it and experiment. You said that the test suite doesn't execute jit-ed code, but it seems like we do execute some jit-ed code in the jitreader.exp test (the code is jit-ed and executed in jithost.c). It might not be too hard to augment it to reproduce the bug (even if it's just hackish at first)? Otherwise, jit-main.c (for jit.exp) takes the approach of copying an ELF file into memory (and adjusting some addresses). It might be possible to lookup a function symbol in this mapped ELF file and execute it? -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 2 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-CC: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Thu, 28 Nov 2019 05:09:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment