* [review] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
@ 2019-11-25 14:06 ` Simon Marchi (Code Review)
2019-11-26 11:27 ` [review v2] " Mihails Strasuns (Code Review)
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Simon Marchi (Code Review) @ 2019-11-25 14:06 UTC (permalink / raw)
To: Mihails Strasuns, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
Patch Set 1:
(1 comment)
Hi Mihails,
Thanks for doing this, I just noted a small comment.
| --- gdb/jit.c
| +++ gdb/jit.c
| @@ -953,17 +953,19 @@ jit_register_code (struct gdbarch *gdbarch,
| }
|
| /* This function unregisters JITed code and frees the corresponding
| objfile. */
|
| static void
| jit_unregister_code (struct objfile *objfile)
| {
| + if (jit_debug)
| + fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%p)\n", objfile);
PS1, Line 962:
For a reason I can't remember, we don't use %p (because it's not
reliable on some platform?). Use "%s" with host_address_to_string
instead.
| delete objfile;
| }
|
| /* Look up the objfile with this code entry address. */
|
| static struct objfile *
| jit_find_objf_with_entry_addr (CORE_ADDR entry_addr)
| {
| for (objfile *objf : current_program_space->objfiles ())
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 1
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Mon, 25 Nov 2019 14:06:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 9+ messages in thread* [review v2] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
2019-11-25 14:06 ` Simon Marchi (Code Review)
@ 2019-11-26 11:27 ` Mihails Strasuns (Code Review)
2019-11-26 11:28 ` Mihails Strasuns (Code Review)
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Mihails Strasuns (Code Review) @ 2019-11-26 11:27 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
jit: minor improvement to debug logging
gdb/ChangeLog:
2019-11-14 Mihails Strasuns <mihails.strasuns@intel.com>
* jit.c (jit_bfd_try_read_symtab): fix printed function name in the
debug output.
* jit.c (jit_unregister_code): add debug print to match
`jit_register_code`.
Signed-off-by: Mihails Strasuns <mihails.strasuns@intel.com>
Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
---
M gdb/jit.c
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/jit.c b/gdb/jit.c
index 85a01ef..480b459 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -874,7 +874,7 @@
if (jit_debug)
fprintf_unfiltered (gdb_stdlog,
- "jit_register_code, symfile_addr = %s, "
+ "jit_bfd_try_read_symtab, symfile_addr = %s, "
"symfile_size = %s\n",
paddress (gdbarch, code_entry->symfile_addr),
pulongest (code_entry->symfile_size));
@@ -958,6 +958,9 @@
static void
jit_unregister_code (struct objfile *objfile)
{
+ if (jit_debug)
+ fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%s)\n",
+ host_address_to_string (objfile));
delete objfile;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 2
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 9+ messages in thread* [review v2] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
2019-11-25 14:06 ` Simon Marchi (Code Review)
2019-11-26 11:27 ` [review v2] " Mihails Strasuns (Code Review)
@ 2019-11-26 11:28 ` Mihails Strasuns (Code Review)
2019-11-26 13:51 ` Tom Tromey (Code Review)
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Mihails Strasuns (Code Review) @ 2019-11-26 11:28 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
Mihails Strasuns has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
Patch Set 2:
(1 comment)
Switched to `host_address_to_string`
| --- gdb/jit.c
| +++ gdb/jit.c
| @@ -953,17 +953,19 @@ jit_register_code (struct gdbarch *gdbarch,
| }
|
| /* This function unregisters JITed code and frees the corresponding
| objfile. */
|
| static void
| jit_unregister_code (struct objfile *objfile)
| {
| + if (jit_debug)
| + fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%p)\n", objfile);
PS1, Line 962:
Done
| delete objfile;
| }
|
| /* Look up the objfile with this code entry address. */
|
| static struct objfile *
| jit_find_objf_with_entry_addr (CORE_ADDR entry_addr)
| {
| for (objfile *objf : current_program_space->objfiles ())
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 2
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 26 Nov 2019 11:28:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 9+ messages in thread* [review v2] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
` (2 preceding siblings ...)
2019-11-26 11:28 ` Mihails Strasuns (Code Review)
@ 2019-11-26 13:51 ` Tom Tromey (Code Review)
2019-11-27 1:08 ` Luis Machado (Code Review)
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-26 13:51 UTC (permalink / raw)
To: Mihails Strasuns, gdb-patches; +Cc: Simon Marchi
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
Patch Set 2: Code-Review+2
Thank you. This is ok.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 2
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 26 Nov 2019 13:51:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 9+ messages in thread* [review v2] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
` (3 preceding siblings ...)
2019-11-26 13:51 ` Tom Tromey (Code Review)
@ 2019-11-27 1:08 ` Luis Machado (Code Review)
2019-11-28 8:48 ` [review v3] " Mihails Strasuns (Code Review)
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Luis Machado (Code Review) @ 2019-11-27 1:08 UTC (permalink / raw)
To: Mihails Strasuns, gdb-patches; +Cc: Tom Tromey, Simon Marchi
Luis Machado has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
Patch Set 2:
Small nit. Use capital letters when starting the ChangeLog sentences.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 2
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Wed, 27 Nov 2019 01:08:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 9+ messages in thread* [review v3] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
` (4 preceding siblings ...)
2019-11-27 1:08 ` Luis Machado (Code Review)
@ 2019-11-28 8:48 ` Mihails Strasuns (Code Review)
2019-11-28 9:07 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-11-28 9:07 ` Sourceware to Gerrit sync (Code Review)
7 siblings, 0 replies; 9+ messages in thread
From: Mihails Strasuns (Code Review) @ 2019-11-28 8:48 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Luis Machado, Simon Marchi
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
jit: minor improvement to debug logging
gdb/ChangeLog:
2019-11-14 Mihails Strasuns <mihails.strasuns@intel.com>
* jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
debug output.
* jit.c (jit_unregister_code): Add debug print to match
`jit_register_code`.
Signed-off-by: Mihails Strasuns <mihails.strasuns@intel.com>
Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
---
M gdb/jit.c
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/jit.c b/gdb/jit.c
index 85a01ef..480b459 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -874,7 +874,7 @@
if (jit_debug)
fprintf_unfiltered (gdb_stdlog,
- "jit_register_code, symfile_addr = %s, "
+ "jit_bfd_try_read_symtab, symfile_addr = %s, "
"symfile_size = %s\n",
paddress (gdbarch, code_entry->symfile_addr),
pulongest (code_entry->symfile_size));
@@ -958,6 +958,9 @@
static void
jit_unregister_code (struct objfile *objfile)
{
+ if (jit_debug)
+ fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%s)\n",
+ host_address_to_string (objfile));
delete objfile;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 3
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 9+ messages in thread* [pushed] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
` (5 preceding siblings ...)
2019-11-28 8:48 ` [review v3] " Mihails Strasuns (Code Review)
@ 2019-11-28 9:07 ` Sourceware to Gerrit sync (Code Review)
2019-11-28 9:07 ` Sourceware to Gerrit sync (Code Review)
7 siblings, 0 replies; 9+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-28 9:07 UTC (permalink / raw)
To: Mihails Strasuns, Tankut Baris Aktemur, gdb-patches
Cc: Luis Machado, Tom Tromey, Simon Marchi
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
jit: minor improvement to debug logging
gdb/ChangeLog:
2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
* jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
debug output.
* jit.c (jit_unregister_code): Add debug print to match
`jit_register_code`.
Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
---
M gdb/ChangeLog
M gdb/jit.c
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6bd149b..49f17ec 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
+
+ * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
+ debug output.
+ * jit.c (jit_unregister_code): Add debug print to match
+ `jit_register_code`.
+
2019-11-27 Christian Biesinger <cbiesinger@google.com>
* NEWS: Mention the new multithreaded symbol loading.
diff --git a/gdb/jit.c b/gdb/jit.c
index 85a01ef..480b459 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -874,7 +874,7 @@
if (jit_debug)
fprintf_unfiltered (gdb_stdlog,
- "jit_register_code, symfile_addr = %s, "
+ "jit_bfd_try_read_symtab, symfile_addr = %s, "
"symfile_size = %s\n",
paddress (gdbarch, code_entry->symfile_addr),
pulongest (code_entry->symfile_size));
@@ -958,6 +958,9 @@
static void
jit_unregister_code (struct objfile *objfile)
{
+ if (jit_debug)
+ fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%s)\n",
+ host_address_to_string (objfile));
delete objfile;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 4
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 9+ messages in thread* [pushed] jit: minor improvement to debug logging
2019-11-25 12:54 [review] jit: minor improvement to debug logging Mihails Strasuns (Code Review)
` (6 preceding siblings ...)
2019-11-28 9:07 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-11-28 9:07 ` Sourceware to Gerrit sync (Code Review)
7 siblings, 0 replies; 9+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-11-28 9:07 UTC (permalink / raw)
To: Mihails Strasuns, Tankut Baris Aktemur, Tom Tromey, gdb-patches
Cc: Luis Machado, Simon Marchi
The original change was created by Mihails Strasuns.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/703
......................................................................
jit: minor improvement to debug logging
gdb/ChangeLog:
2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
* jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
debug output.
* jit.c (jit_unregister_code): Add debug print to match
`jit_register_code`.
Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
---
M gdb/ChangeLog
M gdb/jit.c
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6bd149b..49f17ec 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
+
+ * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
+ debug output.
+ * jit.c (jit_unregister_code): Add debug print to match
+ `jit_register_code`.
+
2019-11-27 Christian Biesinger <cbiesinger@google.com>
* NEWS: Mention the new multithreaded symbol loading.
diff --git a/gdb/jit.c b/gdb/jit.c
index 85a01ef..480b459 100644
--- a/gdb/jit.c
+++ b/gdb/jit.c
@@ -874,7 +874,7 @@
if (jit_debug)
fprintf_unfiltered (gdb_stdlog,
- "jit_register_code, symfile_addr = %s, "
+ "jit_bfd_try_read_symtab, symfile_addr = %s, "
"symfile_size = %s\n",
paddress (gdbarch, code_entry->symfile_addr),
pulongest (code_entry->symfile_size));
@@ -958,6 +958,9 @@
static void
jit_unregister_code (struct objfile *objfile)
{
+ if (jit_debug)
+ fprintf_unfiltered (gdb_stdlog, "jit_unregister_code (%s)\n",
+ host_address_to_string (objfile));
delete objfile;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie66064f3aaa1c74facfc025c8d87f3a057869779
Gerrit-Change-Number: 703
Gerrit-PatchSet: 4
Gerrit-Owner: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Mihails Strasuns <mihails.strasuns@intel.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Luis Machado <luis.machado@linaro.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 9+ messages in thread