From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>
Subject: [review v2] Share Windows thread-suspend and -resume code
Date: Fri, 29 Nov 2019 18:08:00 -0000 [thread overview]
Message-ID: <20191129180833.036E020AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1572371871000.I4e2be5d13faae083d9a83e65425c6c05d5d0e353@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/412
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
| --- gdb/nat/windows-nat.h
| +++ gdb/nat/windows-nat.h
| @@ -13,17 +13,19 @@ /* Internal interfaces for the Windows code
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
| GNU General Public License for more details.
|
| You should have received a copy of the GNU General Public License
| along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
| #ifndef NAT_WINDOWS_NAT_H
| #define NAT_WINDOWS_NAT_H
|
| +#include <windows.h>
PS2, Line 22:
Nothing in this patch is adding code that requires this, so I wondered
why add it here. After looking at the file, I realize that I think
this should have been added right when the nat/windows-nat.h was
created, due to use of DWORD, HANDLE, etc.
| +
| /* Thread information structure used to track extra information about
| each thread. */
| struct windows_thread_info
| {
| windows_thread_info (DWORD tid_, HANDLE h_, CORE_ADDR tlb)
| : tid (tid_),
| h (h_),
| thread_local_base (tlb)
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4e2be5d13faae083d9a83e65425c6c05d5d0e353
Gerrit-Change-Number: 412
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Luis Machado <luis.machado@linaro.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Fri, 29 Nov 2019 18:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
prev parent reply other threads:[~2019-11-29 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 17:58 [review] " Tom Tromey (Code Review)
2019-11-04 14:30 ` Luis Machado (Code Review)
2019-11-06 19:14 ` Tom Tromey (Code Review)
2019-11-26 17:11 ` [review v2] " Tom Tromey (Code Review)
2019-11-29 18:08 ` Pedro Alves (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129180833.036E020AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=luis.machado@linaro.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).