From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90505 invoked by alias); 29 Nov 2019 19:17:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90493 invoked by uid 89); 29 Nov 2019 19:17:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=suspended X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2019 19:17:20 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 5D03320387; Fri, 29 Nov 2019 14:17:19 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 679A020277; Fri, 29 Nov 2019 14:17:18 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 48B2E20AF6; Fri, 29 Nov 2019 14:17:18 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 29 Nov 2019 19:17:00 -0000 From: "Pedro Alves (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Share some Windows-related globals X-Gerrit-Change-Id: I3f861053e285afa3b3fff2d7892fdee2e59ab2c0 X-Gerrit-Change-Number: 710 X-Gerrit-ChangeURL: X-Gerrit-Commit: f9c7eb195a4ba1c7145b9d7cb867a50c86743402 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 29 Nov 2019 14:17:17 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191129191718.48B2E20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-11/txt/msg01151.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/710 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) LGTM, with nit below. | --- gdb/nat/windows-nat.h | +++ gdb/nat/windows-nat.h | @@ -108,7 +150,19 @@ }; | +/* A vector of pending stops. Sometimes, Windows will report a stop | + on a thread that has been ostensibly suspended. We believe what | + happens here is that two threads hit a breakpoint simultaneously, | + and the Windows kernel queues the stop events. However, this can | + result in the strange effect of trying to single step thread A -- | + leaving all other threads suspended -- and then seeing a stop in | + thread B. To handle this scenario, we queue all such "pending" | + stops here, and then process them once the step has completed. See | + PR gdb/22992. */ | +extern std::vector pending_stops; PS1, Line 159: #include . | + | + | /* Return the name of the DLL referenced by H at ADDRESS. UNICODE | determines what sort of string is read from the inferior. Returns | the name of the DLL, or NULL on error. If a name is returned, it | is stored in a static buffer which is valid until the next call to | get_image_name. */ | extern const char *get_image_name (HANDLE h, void *address, int unicode); | -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I3f861053e285afa3b3fff2d7892fdee2e59ab2c0 Gerrit-Change-Number: 710 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Comment-Date: Fri, 29 Nov 2019 19:17:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment