From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>
Subject: [review] Share handle_exception
Date: Fri, 29 Nov 2019 20:05:00 -0000 [thread overview]
Message-ID: <20191129200544.1445A20AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574788288000.I4e6e0d17b868cd51964c273fb28ec066fea6b767@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/716
......................................................................
Patch Set 1:
> Patch Set 1:
>
> I'm confused since gerrit thinks this is a new patch instead of a revision of:
It seems like the Change-Id has been changed between the two revisions.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I4e6e0d17b868cd51964c273fb28ec066fea6b767
Gerrit-Change-Number: 716
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Fri, 29 Nov 2019 20:05:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-11-29 20:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 17:21 Tom Tromey (Code Review)
2019-11-29 20:03 ` Pedro Alves (Code Review)
2019-11-29 20:05 ` Simon Marchi (Code Review) [this message]
2019-11-29 20:51 ` Pedro Alves (Code Review)
2019-11-29 20:57 ` Simon Marchi (Code Review)
2019-12-04 16:20 ` Tom Tromey (Code Review)
2019-12-04 16:32 ` Pedro Alves (Code Review)
-- strict thread matches above, loose matches on Subject: below --
2019-10-29 18:05 Tom Tromey (Code Review)
2019-11-19 19:55 ` Pedro Alves (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129200544.1445A20AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=palves@redhat.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).