From: "Sourceware to Gerrit sync (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Subject: [pushed] Remove stale FIXME comment
Date: Mon, 02 Dec 2019 14:24:00 -0000 [thread overview]
Message-ID: <20191202142406.DC66B2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1574886458000.I2436ca4ae4a6741012cafe8123325f738b692c9c@gnutoolchain-gerrit.osci.io>
The original change was created by Luis Machado.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/732
......................................................................
Remove stale FIXME comment
While debugging something, i noticed this odd FIXME comment. It seems stale
and therefore here's a patch removing it.
gdb/ChangeLog:
2019-12-02 Luis Machado <luis.machado@linaro.org>
* infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
---
M gdb/ChangeLog
M gdb/infrun.c
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1465c75..b8cb710 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-02 Luis Machado <luis.machado@linaro.org>
+
+ * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
+
2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
* dwarf2read.c (read_tag_string_type): Read the fields required to
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 3718674..6a346d6 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -432,7 +432,6 @@
Can not resume the parent process over vfork in the foreground while\n\
holding the child stopped. Try \"set detach-on-fork\" or \
\"set schedule-multiple\".\n"));
- /* FIXME output string > 80 columns. */
return 1;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I2436ca4ae4a6741012cafe8123325f738b692c9c
Gerrit-Change-Number: 732
Gerrit-PatchSet: 2
Gerrit-Owner: Luis Machado <luis.machado@linaro.org>
Gerrit-MessageType: newpatchset
prev parent reply other threads:[~2019-12-02 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 20:27 [review] [Obvious] " Luis Machado (Code Review)
2019-12-02 14:24 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-02 14:24 ` Sourceware to Gerrit sync (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202142406.DC66B2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=noreply@gnutoolchain-gerrit.osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).