From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42346 invoked by alias); 3 Dec 2019 10:25:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42275 invoked by uid 89); 3 Dec 2019 10:25:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1937 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 10:25:27 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id EC9472053D; Tue, 3 Dec 2019 05:25:25 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id D985120334; Tue, 3 Dec 2019 05:25:24 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id CD95A2816F; Tue, 3 Dec 2019 05:25:24 -0500 (EST) X-Gerrit-PatchSet: 10 Date: Tue, 03 Dec 2019 10:25:00 -0000 From: "Andrew Burgess (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Joel Brobecker Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v10] gdb/mi: Add -symbol-info-module-{variables,functions} X-Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe X-Gerrit-Change-Number: 268 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9b3e35abfc9566776d4ed2cad83d645d6264300e In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Dec 2019 05:25:24 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203102524.CD95A2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00087.txt.bz2 Andrew Burgess has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/268 ...................................................................... Patch Set 10: > Patch Set 10: -Code-Review > > Actually, when I try to build (gcc 9.2.0), I get these errors: > > /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:225:8: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror] > 225 | auto iter, > | ^~~~ > /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:226:8: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror] > 226 | auto end, > | ^~~~ > /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:261:6: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror] > 261 | auto iter, > | ^~~~ > /home/simark/src/binutils-gdb/gdb/mi/mi-symbol-cmds.c:262:6: error: use of ‘auto’ in parameter declaration only available with ‘-fconcepts’ [-Werror] > 262 | auto end, > | ^~~~ > > You don't see this? What do you compile with? Gcc 7.3.1 is what's installed on my machine by default. If I switch to a 10.0 compiler then I can reproduce this failure. I've updated the patch and will get a better default version of GCC setup. Sorry for wasting your time with this mistake. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Ic96f12dd14bd7e34774c3cde008fec30a4055bfe Gerrit-Change-Number: 268 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Burgess Gerrit-Reviewer: Andrew Burgess Gerrit-Reviewer: Simon Marchi Gerrit-CC: Joel Brobecker Gerrit-Comment-Date: Tue, 03 Dec 2019 10:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment