[review] Remove gdbarch_bits_big_endian

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729
......................................................................


Patch Set 1:

(1 comment)

| --- gdb/gdbtypes.h
| +++ gdb/gdbtypes.h
| @@ -545,16 +545,15 @@ };
|  
|  union type_owner
|  {
|    struct objfile *objfile;
|    struct gdbarch *gdbarch;
|  };
|  
|  union field_location
|  {
|    /* * Position of this field, counting in bits from start of

PS1, Line 554:

> Could you remove this extra asterisk while at it?

This is for doxygen, which gdbtypes.h (and no other file) generally
uses.
Not sure if we should move toward more doxygen, or remove these; but
either way I'd rather not deal with it in this patch.

Sometimes I think we should fix up "chew" to just extract, and then
write the doc comments in texinfo.

| -     containing structure.  For gdbarch_bits_big_endian=1
| -     targets, it is the bit offset to the MSB.  For
| -     gdbarch_bits_big_endian=0 targets, it is the bit offset to
| -     the LSB.  */
| +     containing structure.  For big-endian targets, it is the bit
| +     offset to the MSB.  For little-endian targets, it is the bit
| +     offset to the LSB.  */
|  
|    LONGEST bitpos;

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018
Gerrit-Change-Number: 729
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Tue, 03 Dec 2019 21:32:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-MessageType: comment