From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121379 invoked by alias); 3 Dec 2019 21:32:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121371 invoked by uid 89); 3 Dec 2019 21:32:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Dec 2019 21:32:42 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id D4E3C20391; Tue, 3 Dec 2019 16:32:40 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id C4C3820391; Tue, 3 Dec 2019 16:32:39 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B2D812816F; Tue, 3 Dec 2019 16:32:39 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Tue, 03 Dec 2019 21:32:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove gdbarch_bits_big_endian X-Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 X-Gerrit-Change-Number: 729 X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d43bc957b28f3a4fd72d675ac463f7a0214dd6a In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Dec 2019 16:32:39 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191203213239.B2D812816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00107.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/729 ...................................................................... Patch Set 1: (1 comment) | --- gdb/gdbtypes.h | +++ gdb/gdbtypes.h | @@ -545,16 +545,15 @@ }; | | union type_owner | { | struct objfile *objfile; | struct gdbarch *gdbarch; | }; | | union field_location | { | /* * Position of this field, counting in bits from start of PS1, Line 554: > Could you remove this extra asterisk while at it? This is for doxygen, which gdbtypes.h (and no other file) generally uses. Not sure if we should move toward more doxygen, or remove these; but either way I'd rather not deal with it in this patch. Sometimes I think we should fix up "chew" to just extract, and then write the doc comments in texinfo. | - containing structure. For gdbarch_bits_big_endian=1 | - targets, it is the bit offset to the MSB. For | - gdbarch_bits_big_endian=0 targets, it is the bit offset to | - the LSB. */ | + containing structure. For big-endian targets, it is the bit | + offset to the MSB. For little-endian targets, it is the bit | + offset to the LSB. */ | | LONGEST bitpos; -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I379b5e0c408ec8742f7a6c6b721108e73ed1b018 Gerrit-Change-Number: 729 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Tue, 03 Dec 2019 21:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Marchi Gerrit-MessageType: comment