From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55084 invoked by alias); 4 Dec 2019 16:20:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54995 invoked by uid 89); 4 Dec 2019 16:20:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 16:20:04 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id CC10920422; Wed, 4 Dec 2019 11:20:02 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 98AF9202E5; Wed, 4 Dec 2019 11:19:58 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 786F02816F; Wed, 4 Dec 2019 11:19:58 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Wed, 04 Dec 2019 16:20:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi , Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Share handle_exception X-Gerrit-Change-Id: I4e6e0d17b868cd51964c273fb28ec066fea6b767 X-Gerrit-Change-Number: 716 X-Gerrit-ChangeURL: X-Gerrit-Commit: af02ef9ff229d33502ed385327036e8688d94758 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 4 Dec 2019 11:19:58 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191204161958.786F02816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00141.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/716 ...................................................................... Patch Set 1: > Patch Set 1: > > I'm confused since gerrit thinks this is a new patch instead of a revision of: > > https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/425 > > Did you consider not having the new callbacks and instead install target_ops::thread_name on gdbserver too? I tried today. There's no shared target_read_string API, and I don't want to add any more things to this series than are strictly required -- it's already too long. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I4e6e0d17b868cd51964c273fb28ec066fea6b767 Gerrit-Change-Number: 716 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 04 Dec 2019 16:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment