* [review] Silence ARI warning about floatformat_to_double
@ 2019-12-05 15:45 Tom Tromey (Code Review)
2019-12-05 16:50 ` Pedro Alves (Code Review)
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-05 15:45 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................
Silence ARI warning about floatformat_to_double
This silences ARI at the one spot that is permitted to call
floatformat_to_double.
gdb/ChangeLog
2019-12-05 Tom Tromey <tromey@adacore.com>
* target-float.c (host_float_ops<T>::from_target): Add ARI
comment.
Change-Id: I778a17a04da417c113194004dd7de3b1df381266
---
M gdb/ChangeLog
M gdb/target-float.c
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 36f407f..fe81ff8 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * target-float.c (host_float_ops<T>::from_target): Add ARI
+ comment.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* utils.c (abort_with_message, dump_core, internal_vproblem): Add
ARI marker to abort.
* event-top.c (handle_sigsegv): Add ARI marker to abort.
diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943..ddf20c8 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@
{
double dto;
- floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
- from, &dto);
+ floatformat_to_double /* ARI: floatformat_to_double */
+ (fmt->split_half ? fmt->split_half : fmt, from, &dto);
*to = (T) dto;
return;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266
Gerrit-Change-Number: 745
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Silence ARI warning about floatformat_to_double
2019-12-05 15:45 [review] Silence ARI warning about floatformat_to_double Tom Tromey (Code Review)
@ 2019-12-05 16:50 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-05 16:50 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................
Patch Set 1: Code-Review+2
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266
Gerrit-Change-Number: 745
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 16:50:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review v2] Silence ARI warning about floatformat_to_double
2019-12-05 15:45 [review] Silence ARI warning about floatformat_to_double Tom Tromey (Code Review)
2019-12-05 16:50 ` Pedro Alves (Code Review)
@ 2019-12-12 17:51 ` Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 17:51 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................
Silence ARI warning about floatformat_to_double
This silences ARI at the one spot that is permitted to call
floatformat_to_double, and also removes the corresponding "fix" call
from gdb_ari.sh -- it was incorrect, and now is not needed.
2019-12-12 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "fix" call for
floatformat_to_double.
* target-float.c (host_float_ops<T>::from_target): Add ARI
comment.
Change-Id: I778a17a04da417c113194004dd7de3b1df381266
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
M gdb/target-float.c
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 34e5c64..709bd27 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2019-12-12 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove "fix" call for
+ floatformat_to_double.
+ * target-float.c (host_float_ops<T>::from_target): Add ARI
+ comment.
+
+2019-12-12 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
* utils.c (abort_with_message, dump_core, internal_vproblem): Add
ARI marker to abort.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 300ed76..9a5b941 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -810,7 +810,6 @@
BEGIN { doc["floatformat_to_double"] = "\
Do not use floatformat_to_double() from libierty, \
instead use floatformat_to_doublest()"
- fix("floatformat_to_double", "gdb/doublest.c", 1)
category["floatformat_to_double"] = ari_regression
}
/(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {
diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943..ddf20c8 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@
{
double dto;
- floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
- from, &dto);
+ floatformat_to_double /* ARI: floatformat_to_double */
+ (fmt->split_half ? fmt->split_half : fmt, from, &dto);
*to = (T) dto;
return;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266
Gerrit-Change-Number: 745
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Silence ARI warning about floatformat_to_double
2019-12-05 15:45 [review] Silence ARI warning about floatformat_to_double Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................
Silence ARI warning about floatformat_to_double
This silences ARI at the one spot that is permitted to call
floatformat_to_double, and also removes the corresponding "fix" call
from gdb_ari.sh -- it was incorrect, and now is not needed.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "fix" call for
floatformat_to_double.
* target-float.c (host_float_ops<T>::from_target): Add ARI
comment.
Change-Id: I778a17a04da417c113194004dd7de3b1df381266
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
M gdb/target-float.c
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44bb65f..d107b6c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove "fix" call for
+ floatformat_to_double.
+ * target-float.c (host_float_ops<T>::from_target): Add ARI
+ comment.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
* utils.c (abort_with_message, dump_core, internal_vproblem): Add
ARI marker to abort.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 300ed76..9a5b941 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -810,7 +810,6 @@
BEGIN { doc["floatformat_to_double"] = "\
Do not use floatformat_to_double() from libierty, \
instead use floatformat_to_doublest()"
- fix("floatformat_to_double", "gdb/doublest.c", 1)
category["floatformat_to_double"] = ari_regression
}
/(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {
diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943..ddf20c8 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@
{
double dto;
- floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
- from, &dto);
+ floatformat_to_double /* ARI: floatformat_to_double */
+ (fmt->split_half ? fmt->split_half : fmt, from, &dto);
*to = (T) dto;
return;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266
Gerrit-Change-Number: 745
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Silence ARI warning about floatformat_to_double
2019-12-05 15:45 [review] Silence ARI warning about floatformat_to_double Tom Tromey (Code Review)
2019-12-05 16:50 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, Pedro Alves, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745
......................................................................
Silence ARI warning about floatformat_to_double
This silences ARI at the one spot that is permitted to call
floatformat_to_double, and also removes the corresponding "fix" call
from gdb_ari.sh -- it was incorrect, and now is not needed.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "fix" call for
floatformat_to_double.
* target-float.c (host_float_ops<T>::from_target): Add ARI
comment.
Change-Id: I778a17a04da417c113194004dd7de3b1df381266
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
M gdb/target-float.c
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 44bb65f..d107b6c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove "fix" call for
+ floatformat_to_double.
+ * target-float.c (host_float_ops<T>::from_target): Add ARI
+ comment.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
* utils.c (abort_with_message, dump_core, internal_vproblem): Add
ARI marker to abort.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 300ed76..9a5b941 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -810,7 +810,6 @@
BEGIN { doc["floatformat_to_double"] = "\
Do not use floatformat_to_double() from libierty, \
instead use floatformat_to_doublest()"
- fix("floatformat_to_double", "gdb/doublest.c", 1)
category["floatformat_to_double"] = ari_regression
}
/(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ {
diff --git a/gdb/target-float.c b/gdb/target-float.c
index caa6943..ddf20c8 100644
--- a/gdb/target-float.c
+++ b/gdb/target-float.c
@@ -647,8 +647,8 @@
{
double dto;
- floatformat_to_double (fmt->split_half ? fmt->split_half : fmt,
- from, &dto);
+ floatformat_to_double /* ARI: floatformat_to_double */
+ (fmt->split_half ? fmt->split_half : fmt, from, &dto);
*to = (T) dto;
return;
}
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266
Gerrit-Change-Number: 745
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 22:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 15:45 [review] Silence ARI warning about floatformat_to_double Tom Tromey (Code Review)
2019-12-05 16:50 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).