From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review] Avoid ARI warnings with #include
Date: Thu, 05 Dec 2019 16:55:00 -0000 [thread overview]
Message-ID: <20191205165519.269222816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1575560698000.I215683952dec75379ea0a259e79c8dafbae210b9@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/746
......................................................................
Patch Set 1:
(1 comment)
| --- gdb/gdb_vfork.h
| +++ gdb/gdb_vfork.h
| @@ -13,14 +13,14 @@ /* GDB-friendly replacement for <vfork.h>.
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
| GNU General Public License for more details.
|
| You should have received a copy of the GNU General Public License
| along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
| #ifndef GDB_VFORK_H
| #define GDB_VFORK_H
|
| #if HAVE_VFORK_H
| -#include <vfork.h>
| +#include <vfork.h> /* ARI: vfork.h */
| #endif
PS1, Line 24:
Isn't this:
BEGIN { doc["vfork.h"] = "\
Do not include vfork.h, instead include gdb_vfork.h"
fix("vfork.h", "gdb/gdb_vfork.h", 1);
^^^^^^^^^^^^^^^
category["vfork.h"] = ari_regression
}
... supposed to suppress this case?
Same for the gdb_regex.h file.
|
| #endif /* GDB_VFORK_H */
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9
Gerrit-Change-Number: 746
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 16:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-12-05 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 15:51 Tom Tromey (Code Review)
2019-12-05 16:55 ` Pedro Alves (Code Review) [this message]
2019-12-05 16:57 ` Pedro Alves (Code Review)
2019-12-12 17:22 ` Tom Tromey (Code Review)
2019-12-13 14:35 ` Pedro Alves (Code Review)
2019-12-16 19:23 ` Tom Tromey (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205165519.269222816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).