From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20244 invoked by alias); 5 Dec 2019 16:59:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20216 invoked by uid 89); 5 Dec 2019 16:59:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Dec 2019 16:59:20 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 39B8B204BA; Thu, 5 Dec 2019 11:59:19 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 5199B2012A; Thu, 5 Dec 2019 11:59:14 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3077F2816F; Thu, 5 Dec 2019 11:59:14 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 05 Dec 2019 16:59:00 -0000 From: "Christian Biesinger (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Cc: Christian Biesinger , Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove "boolean" and "var_boolean" checks from ARI X-Gerrit-Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67 X-Gerrit-Change-Number: 741 X-Gerrit-ChangeURL: X-Gerrit-Commit: a7071c5f5e8e2b072de611b66b3e6e0e9ae817d3 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 5 Dec 2019 11:59:13 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191205165914.3077F2816F@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00199.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741 ...................................................................... Patch Set 1: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +3,19 @@ Author: Tom Tromey | +AuthorDate: 2019-12-05 07:53:32 -0700 | +Commit: Tom Tromey | +CommitDate: 2019-12-05 07:53:32 -0700 | + | +Remove "boolean" and "var_boolean" checks from ARI | + | +The "boolean" and "var_boolean" checks from ARI seem only to generate | +false reports. | + | +Now that gdb is in C++, at least the "boolean" check seems unlikely to PS1, Line 12: I don't understand, the check suggests using bool instead of boolean. So presumably it was added specifically for c++? Still seems fine to remove it since I don't know why anyone would write boolean. | +ever generate a true report. | + | +The "var_boolean" check likewise doesn't seem valuable any more -- | +presumably this refers to some ancient way of doing things in gdb, and | +isn't likely to find a bug in the future. | + | +Therefore, this patch removes these two checks. | + | +gdb/ChangeLog -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67 Gerrit-Change-Number: 741 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-CC: Christian Biesinger Gerrit-Comment-Date: Thu, 05 Dec 2019 16:59:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment