From: "Pedro Alves (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review] Change ARI usage to GNU style
Date: Thu, 05 Dec 2019 17:02:00 -0000 [thread overview]
Message-ID: <20191205170203.2763C2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1575560698000.Ibe5a867571382d2985d1b8b78dfef3ddd02291ff@gnutoolchain-gerrit.osci.io>
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Patch Set 1:
(1 comment)
| --- gdb/contrib/ari/gdb_ari.sh
| +++ gdb/contrib/ari/gdb_ari.sh
| @@ -56,17 +55,18 @@ Usage:
| + $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
| Options:
| --print-doc Print a list of all potential problems, then exit.
| --print-idx Include the problems IDX (index or key) in every message.
| --src=file Write source lines to file.
| -Werror Treat all problems as errors.
| -Wall Report all problems.
| -Wari Report problems that should be fixed in new code.
| - -W<category> Report problems in the specifed category. Valid categories
| + -WCATEGORY Report problems in the specifed category. Valid categories
PS1, Line 63:
The disadvantage here is that W is also uppercase. In this case it
looks unambiguous enough, though. Not sure this is an improvement
because of that, but I guess it is fine.
| are: ${all}
| EOF
| exit 1
| }
|
|
| # Parse the various options
| Woptions=
| srclines=""
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 17:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-12-05 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 15:45 Tom Tromey (Code Review)
2019-12-05 17:02 ` Pedro Alves (Code Review) [this message]
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205170203.2763C2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).