* [review] Change ARI usage to GNU style
@ 2019-12-05 15:45 Tom Tromey (Code Review)
2019-12-05 17:02 ` Pedro Alves (Code Review)
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-05 15:45 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Change ARI usage to GNU style
This changes the ARI usage text to use the GNU style for
"metasyntactic variables".
gdb/ChangeLog
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e4259c4..3c7e592 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh (usage): Use GNU style.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* gdbsupport/agent.c (gdb_connect_sync_socket): Use
safe_strerror.
(gdb_connect_sync_socket): Use safe_strerror.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index d05f4af..5b74506 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -52,7 +52,7 @@
Error: $1
Usage:
- $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
+ $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
Options:
--print-doc Print a list of all potential problems, then exit.
--print-idx Include the problems IDX (index or key) in every message.
@@ -60,7 +60,7 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -W<category> Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. Valid categories
are: ${all}
EOF
exit 1
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Change ARI usage to GNU style
2019-12-05 15:45 [review] Change ARI usage to GNU style Tom Tromey (Code Review)
@ 2019-12-05 17:02 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-05 17:02 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Patch Set 1:
(1 comment)
| --- gdb/contrib/ari/gdb_ari.sh
| +++ gdb/contrib/ari/gdb_ari.sh
| @@ -56,17 +55,18 @@ Usage:
| + $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
| Options:
| --print-doc Print a list of all potential problems, then exit.
| --print-idx Include the problems IDX (index or key) in every message.
| --src=file Write source lines to file.
| -Werror Treat all problems as errors.
| -Wall Report all problems.
| -Wari Report problems that should be fixed in new code.
| - -W<category> Report problems in the specifed category. Valid categories
| + -WCATEGORY Report problems in the specifed category. Valid categories
PS1, Line 63:
The disadvantage here is that W is also uppercase. In this case it
looks unambiguous enough, though. Not sure this is an improvement
because of that, but I guess it is fine.
| are: ${all}
| EOF
| exit 1
| }
|
|
| # Parse the various options
| Woptions=
| srclines=""
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 17:02:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review v2] Change ARI usage to GNU style
2019-12-05 15:45 [review] Change ARI usage to GNU style Tom Tromey (Code Review)
2019-12-05 17:02 ` Pedro Alves (Code Review)
@ 2019-12-12 17:51 ` Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 17:51 UTC (permalink / raw)
To: gdb-patches; +Cc: Pedro Alves
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Change ARI usage to GNU style
This changes the ARI usage text to use the GNU style for
"metasyntactic variables".
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 92d76fa..e743677 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh (usage): Use GNU style.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* gdbsupport/common-utils.c (string_printf, string_vprintf)
(string_vappendf): Add ARI comment.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 9a5b941..4b0fddf 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -52,7 +52,7 @@
Error: $1
Usage:
- $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
+ $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
Options:
--print-doc Print a list of all potential problems, then exit.
--print-idx Include the problems IDX (index or key) in every message.
@@ -60,7 +60,7 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -W<category> Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. Valid categories
are: ${all}
EOF
exit 1
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Change ARI usage to GNU style
2019-12-05 15:45 [review] Change ARI usage to GNU style Tom Tromey (Code Review)
2019-12-05 17:02 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Change ARI usage to GNU style
This changes the ARI usage text to use the GNU style for
"metasyntactic variables".
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0e1f484..93b0762 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh (usage): Use GNU style.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* gdbsupport/common-utils.c (string_printf, string_vprintf)
(string_vappendf): Add ARI comment.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 9a5b941..4b0fddf 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -52,7 +52,7 @@
Error: $1
Usage:
- $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
+ $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
Options:
--print-doc Print a list of all potential problems, then exit.
--print-idx Include the problems IDX (index or key) in every message.
@@ -60,7 +60,7 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -W<category> Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. Valid categories
are: ${all}
EOF
exit 1
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Change ARI usage to GNU style
2019-12-05 15:45 [review] Change ARI usage to GNU style Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/749
......................................................................
Change ARI usage to GNU style
This changes the ARI usage text to use the GNU style for
"metasyntactic variables".
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0e1f484..93b0762 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh (usage): Use GNU style.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* gdbsupport/common-utils.c (string_printf, string_vprintf)
(string_vappendf): Add ARI comment.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 9a5b941..4b0fddf 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -52,7 +52,7 @@
Error: $1
Usage:
- $0 --print-doc --print-idx -Wall -Werror -W<category> <file> ...
+ $0 --print-doc --print-idx -Wall -Werror -WCATEGORY FILE ...
Options:
--print-doc Print a list of all potential problems, then exit.
--print-idx Include the problems IDX (index or key) in every message.
@@ -60,7 +60,7 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -W<category> Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. Valid categories
are: ${all}
EOF
exit 1
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ibe5a867571382d2985d1b8b78dfef3ddd02291ff
Gerrit-Change-Number: 749
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 22:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 15:45 [review] Change ARI usage to GNU style Tom Tromey (Code Review)
2019-12-05 17:02 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).