From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>, Keith Seitz <keiths@redhat.com>
Subject: [review] gdb: fix overload resolution for see-through references
Date: Thu, 05 Dec 2019 20:13:00 -0000 [thread overview]
Message-ID: <20191205201350.7F07D2816F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573572186000.I39ae6505ab85ad0bd21915368c82540ceeb3aae9@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/617
......................................................................
Patch Set 1: Code-Review+2
Thank you for doing this. I appreciated the explanation.
The patch looks good to me.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I39ae6505ab85ad0bd21915368c82540ceeb3aae9
Gerrit-Change-Number: 617
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Keith Seitz <keiths@redhat.com>
Gerrit-Reviewer: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Simon Marchi <simon.marchi@polymtl.ca>
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:13:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-12-05 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:23 Tankut Baris Aktemur (Code Review)
2019-11-27 7:46 ` Tankut Baris Aktemur (Code Review)
2019-11-29 16:43 ` Simon Marchi (Code Review)
2019-11-29 18:57 ` Tankut Baris Aktemur (Code Review)
2019-12-05 20:13 ` Tom Tromey (Code Review) [this message]
2019-12-06 7:25 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205201350.7F07D2816F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
--cc=keiths@redhat.com \
--cc=simon.marchi@polymtl.ca \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).