* [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
@ 2019-11-12 15:23 Tankut Baris Aktemur (Code Review)
2019-12-05 20:14 ` Tom Tromey (Code Review)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tankut Baris Aktemur (Code Review) @ 2019-11-12 15:23 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................
gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
Simplify the expected test outputs. This is a minor cleanup; no
functional change is intended.
gdb/testsuite/ChangeLog:
2019-11-12 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.cp/rvalue-ref-overload.exp: Minor cleanup.
Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
---
M gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
index 693c7ca..e92e901 100644
--- a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
+++ b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
@@ -53,20 +53,16 @@
{ method public "int overloadConst(const foo &&);" }
}
-gdb_test "print foo_rr_instance1.overload1arg(arg)" \
- "\\$\[0-9\]+ = 1" \
- "print call overloaded func foo & arg"
+gdb_test "print foo_rr_instance1.overload1arg(arg)" "1"
-gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" \
- "\\$\[0-9\]+ = 2" \
- "print call overloaded func foo && arg"
+gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" "2"
gdb_test "print foo_rr_instance1.overloadConst(arg)" "3"
# Test lvalue vs rvalue function overloads
-gdb_test "print f (i)" "= 1" "lvalue reference overload"
+gdb_test "print f (i)" "1" "lvalue reference overload"
-gdb_test "print f (ci)" "= 2" "lvalue reference to const overload"
+gdb_test "print f (ci)" "2" "lvalue reference to const overload"
setup_kfail "c++/15372" "*-*-*"
-gdb_test "print f (3)" "= 3" "rvalue reference overload"
+gdb_test "print f (3)" "3" "rvalue reference overload"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 4+ messages in thread
* [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
2019-11-12 15:23 [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp Tankut Baris Aktemur (Code Review)
@ 2019-12-05 20:14 ` Tom Tromey (Code Review)
2019-12-06 7:25 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-05 20:14 UTC (permalink / raw)
To: Tankut Baris Aktemur, gdb-patches
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................
Patch Set 1: Code-Review+2
Thank you. This is ok.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 1
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 05 Dec 2019 20:14:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
2019-11-12 15:23 [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp Tankut Baris Aktemur (Code Review)
2019-12-05 20:14 ` Tom Tromey (Code Review)
2019-12-06 7:25 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-06 7:25 UTC (permalink / raw)
To: Tankut Baris Aktemur, Tom Tromey, gdb-patches
The original change was created by Tankut Baris Aktemur.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................
gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
Simplify the expected test outputs. This is a minor cleanup; no
functional change is intended.
gdb/testsuite/ChangeLog:
2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.cp/rvalue-ref-overload.exp: Minor cleanup.
Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index adbbd9c..f7447dc 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
+ * gdb.cp/rvalue-ref-overload.exp: Minor cleanup.
+
+2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
+
* gdb.cp/rvalue-ref-overload.cc: Add a case that involves both
CV and reference conversion for overload resolution.
* gdb.cp/rvalue-ref-overload.exp: Test it.
diff --git a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
index 693c7ca..e92e901 100644
--- a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
+++ b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
@@ -53,20 +53,16 @@
{ method public "int overloadConst(const foo &&);" }
}
-gdb_test "print foo_rr_instance1.overload1arg(arg)" \
- "\\$\[0-9\]+ = 1" \
- "print call overloaded func foo & arg"
+gdb_test "print foo_rr_instance1.overload1arg(arg)" "1"
-gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" \
- "\\$\[0-9\]+ = 2" \
- "print call overloaded func foo && arg"
+gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" "2"
gdb_test "print foo_rr_instance1.overloadConst(arg)" "3"
# Test lvalue vs rvalue function overloads
-gdb_test "print f (i)" "= 1" "lvalue reference overload"
+gdb_test "print f (i)" "1" "lvalue reference overload"
-gdb_test "print f (ci)" "= 2" "lvalue reference to const overload"
+gdb_test "print f (ci)" "2" "lvalue reference to const overload"
setup_kfail "c++/15372" "*-*-*"
-gdb_test "print f (3)" "= 3" "rvalue reference overload"
+gdb_test "print f (3)" "3" "rvalue reference overload"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 2
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
2019-11-12 15:23 [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp Tankut Baris Aktemur (Code Review)
2019-12-05 20:14 ` Tom Tromey (Code Review)
@ 2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-06 7:25 UTC (permalink / raw)
To: Tankut Baris Aktemur, gdb-patches; +Cc: Tom Tromey
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/618
......................................................................
gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp
Simplify the expected test outputs. This is a minor cleanup; no
functional change is intended.
gdb/testsuite/ChangeLog:
2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* gdb.cp/rvalue-ref-overload.exp: Minor cleanup.
Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
---
M gdb/testsuite/ChangeLog
M gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index adbbd9c..f7447dc 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
+ * gdb.cp/rvalue-ref-overload.exp: Minor cleanup.
+
+2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
+
* gdb.cp/rvalue-ref-overload.cc: Add a case that involves both
CV and reference conversion for overload resolution.
* gdb.cp/rvalue-ref-overload.exp: Test it.
diff --git a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
index 693c7ca..e92e901 100644
--- a/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
+++ b/gdb/testsuite/gdb.cp/rvalue-ref-overload.exp
@@ -53,20 +53,16 @@
{ method public "int overloadConst(const foo &&);" }
}
-gdb_test "print foo_rr_instance1.overload1arg(arg)" \
- "\\$\[0-9\]+ = 1" \
- "print call overloaded func foo & arg"
+gdb_test "print foo_rr_instance1.overload1arg(arg)" "1"
-gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" \
- "\\$\[0-9\]+ = 2" \
- "print call overloaded func foo && arg"
+gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" "2"
gdb_test "print foo_rr_instance1.overloadConst(arg)" "3"
# Test lvalue vs rvalue function overloads
-gdb_test "print f (i)" "= 1" "lvalue reference overload"
+gdb_test "print f (i)" "1" "lvalue reference overload"
-gdb_test "print f (ci)" "= 2" "lvalue reference to const overload"
+gdb_test "print f (ci)" "2" "lvalue reference to const overload"
setup_kfail "c++/15372" "*-*-*"
-gdb_test "print f (3)" "= 3" "rvalue reference overload"
+gdb_test "print f (3)" "3" "rvalue reference overload"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Ie760a2856cae3be0eeed5496765a5f1cd102d6b7
Gerrit-Change-Number: 618
Gerrit-PatchSet: 2
Gerrit-Owner: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-06 7:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 15:23 [review] gdb/testsuite: do minor clean-up in gdb.cp/rvalue-ref-overload.exp Tankut Baris Aktemur (Code Review)
2019-12-05 20:14 ` Tom Tromey (Code Review)
2019-12-06 7:25 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-06 7:25 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).