From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81072 invoked by alias); 11 Dec 2019 09:24:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81042 invoked by uid 89); 11 Dec 2019 09:24:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2019 09:24:28 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 51140201E8; Wed, 11 Dec 2019 04:24:26 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 4AEBF201E8; Wed, 11 Dec 2019 04:24:23 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 257BB20AF6; Wed, 11 Dec 2019 04:24:23 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 11 Dec 2019 09:24:00 -0000 From: "Mihails Strasuns (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Luis Machado , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] jit: remove bp locations when unregistering jit code X-Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 X-Gerrit-Change-Number: 704 X-Gerrit-ChangeURL: X-Gerrit-Commit: 232c479ef55b074173b1547b2072916bba6904c2 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Dec 2019 04:24:22 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191211092423.257BB20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00406.txt.bz2 Mihails Strasuns has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/704 ...................................................................... Patch Set 2: > I'm a bit lost in how all this interacts with opencl though. Can you explain how the jit comes in play with opencl? Is there a jit reader for opencl? In the tests, how can we put a breakpoint on "testkernel", where does that symbol come from? I am only using it as an easy way to get already relocated elf binary with the debug info present. The way it works with the CPU runtime I am using locally is that compiling opencl kernel generates elf which is loaded into memory and passed via __jit_debug_register_code - pretty much the same behavior you would get with hypothetically adjusted jit-main.c But indeed this is an implementation detail and cannot be relied on for a general purpose test case :/ > > It is still something I'd really like to make work because currently there is no easy testing facility for more complex jit tests in gdb. Maybe reusing dwarf processing bits from gdb itself can make it feasible, will have to give it a try. > > I agree, the more advanced use cases need to be tested. I will try to come up with something but can't give any ETA right now. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: Id9133540d67fa0c4619ac88324b0349b89e4b2b1 Gerrit-Change-Number: 704 Gerrit-PatchSet: 2 Gerrit-Owner: Mihails Strasuns Gerrit-Reviewer: Mihails Strasuns Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-CC: Luis Machado Gerrit-CC: Simon Marchi Gerrit-Comment-Date: Wed, 11 Dec 2019 09:24:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment