From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Subject: [review] Don't call tui_show_source from tui_ui_out
Date: Thu, 12 Dec 2019 02:31:00 -0000 [thread overview]
Message-ID: <20191212023143.5E3D520AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573774548000.Id71098e597ee4ebfef0429562baa45f537bd2c2b@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/652
......................................................................
Patch Set 1:
> Patch Set 1:
>
> I am am going to check in this series once I've re-tested it.
> Rebasing today required some minor updates to one of the patches.
Testing showed that this was optimistic, so instead I'm going to submit v2.
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Id71098e597ee4ebfef0429562baa45f537bd2c2b
Gerrit-Change-Number: 652
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-Comment-Date: Thu, 12 Dec 2019 02:31:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
next prev parent reply other threads:[~2019-12-12 2:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 23:41 Tom Tromey (Code Review)
2019-12-11 23:28 ` Tom Tromey (Code Review)
2019-12-12 2:31 ` Tom Tromey (Code Review) [this message]
2019-12-12 2:35 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:15 ` Tom Tromey (Code Review)
2019-12-20 16:21 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212023143.5E3D520AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=gnutoolchain-gerrit@osci.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).