From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: gdb-patches@sourceware.org
Subject: [review v2] Remove parameters from tui_show_source
Date: Thu, 12 Dec 2019 02:35:00 -0000 [thread overview]
Message-ID: <20191212023504.7D53225BB4@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1573774548000.I7cbcf20175b459c269549f1832d4fb844cc573db@gnutoolchain-gerrit.osci.io>
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................
Remove parameters from tui_show_source
tui_show_source does not need its parameters, so this removes them.
gdb/ChangeLog
2019-12-11 Tom Tromey <tom@tromey.com>
* tui/tui.h (tui_show_source): Remove parameters.
* tui/tui.c (tui_show_source): Remove parameters.
* tui/tui-out.c (tui_ui_out::do_field_string): Update.
Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3dd12c3..ed79ccd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2019-12-11 Tom Tromey <tom@tromey.com>
+ * tui/tui.h (tui_show_source): Remove parameters.
+ * tui/tui.c (tui_show_source): Remove parameters.
+ * tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-12-11 Tom Tromey <tom@tromey.com>
+
* tui/tui.c (tui_show_source): Update.
* tui/tui-winsource.c (tui_display_main): Update.
* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@
if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
{
- tui_show_source (string, m_line);
+ tui_show_source ();
return;
}
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 8bffb30..deb6bb2 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -627,14 +627,14 @@
#endif
void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
{
struct symtab_and_line cursal = get_current_source_symtab_and_line ();
/* Make sure that the source window is displayed. */
tui_add_win_to_layout (SRC_WIN);
- tui_update_source_windows_with_line (cursal.symtab, line);
+ tui_update_source_windows_with_line (cursal.symtab, cursal.line);
tui_update_locator_fullname (cursal.symtab);
}
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@
extern int tui_active;
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
#endif /* TUI_TUI_H */
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
Gerrit-Change-Number: 631
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
next prev parent reply other threads:[~2019-12-12 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 23:35 [review] " Tom Tromey (Code Review)
2019-12-12 2:35 ` Tom Tromey (Code Review) [this message]
2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212023504.7D53225BB4@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).