[review] Remove "boolean" and "var_boolean" checks from ARI

["Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>]

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................


Patch Set 1:

(1 comment)

| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +3,19 @@ Author:     Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-05 07:53:32 -0700
| +Commit:     Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-05 07:53:32 -0700
| +
| +Remove "boolean" and "var_boolean" checks from ARI
| +
| +The "boolean" and "var_boolean" checks from ARI seem only to generate
| +false reports.
| +
| +Now that gdb is in C++, at least the "boolean" check seems unlikely to

PS1, Line 12:

> I don't understand, the check suggests using bool instead of boolean. So presumably it was added specifically for c++? Still seems fine to remove it since I don't know why anyone would write boolean.

I am not sure but it may refer to some older typedef?
I don't know but basically it's not relevant any longer.

| +ever generate a true report.
| +
| +The "var_boolean" check likewise doesn't seem valuable any more --
| +presumably this refers to some ancient way of doing things in gdb, and
| +isn't likely to find a bug in the future.
| +
| +Therefore, this patch removes these two checks.
| +
| +gdb/ChangeLog

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
Gerrit-Change-Number: 741
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-Comment-Date: Thu, 12 Dec 2019 17:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: comment