From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8001 invoked by alias); 12 Dec 2019 17:21:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7993 invoked by uid 89); 12 Dec 2019 17:21:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 17:21:09 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6210A20391; Thu, 12 Dec 2019 12:21:08 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6065F202F7; Thu, 12 Dec 2019 12:21:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 385FD20AF6; Thu, 12 Dec 2019 12:21:07 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 12 Dec 2019 17:21:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Silence ARI for valid calls to abort X-Gerrit-Change-Id: I09ce6aa5010bbe4e5bb73ffdb727481be39d34d6 X-Gerrit-Change-Number: 744 X-Gerrit-ChangeURL: X-Gerrit-Commit: 424c4ec8259eb64c1249309bc96a68c6fac7cfeb In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 12 Dec 2019 12:21:06 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191212172107.385FD20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00523.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/744 ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+2 > > Ahaha, yeah, I forgot to point at that "only 3 calls" comment in the threads series. :-) I see now there's a fix() call about this in gdb_ari.sh. In general I think these fix() calls should be removed in favor of annotations at the point of call. I'll comment on that in another patch as well. -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I09ce6aa5010bbe4e5bb73ffdb727481be39d34d6 Gerrit-Change-Number: 744 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Pedro Alves Gerrit-Reviewer: Tom Tromey Gerrit-Comment-Date: Thu, 12 Dec 2019 17:21:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment