From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9911 invoked by alias); 12 Dec 2019 17:22:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9897 invoked by uid 89); 12 Dec 2019 17:22:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 17:22:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id F2BA0202F7; Thu, 12 Dec 2019 12:22:31 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id C81D9202F7; Thu, 12 Dec 2019 12:22:29 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id B980220AF6; Thu, 12 Dec 2019 12:22:29 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Thu, 12 Dec 2019 17:22:00 -0000 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Pedro Alves Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Avoid ARI warnings with #include X-Gerrit-Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9 X-Gerrit-Change-Number: 746 X-Gerrit-ChangeURL: X-Gerrit-Commit: f26577b5c12dc6a600abca1e0ba0239d62f1b211 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 12 Dec 2019 12:22:29 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191212172229.B980220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00524.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/746 ...................................................................... Patch Set 1: (1 comment) | --- gdb/gdb_vfork.h | +++ gdb/gdb_vfork.h | @@ -13,14 +13,14 @@ /* GDB-friendly replacement for . | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | GNU General Public License for more details. | | You should have received a copy of the GNU General Public License | along with this program. If not, see . */ | | #ifndef GDB_VFORK_H | #define GDB_VFORK_H | | #if HAVE_VFORK_H | -#include | +#include /* ARI: vfork.h */ | #endif PS1, Line 24: > > Isn't this: > ... > > ... supposed to suppress this case? > > Note, I wouldn't be opposed to always tag in the header file directly. > But in that case, it seems like the patch should remove the fix() call from > the ARI at the same time. > > But I'm curious why that isn't working. I ran it incorrectly -- I ran it from the gdb directory, but actually you have to run it from the top-level source directory, so that the paths match. This is one reason I think removing the fix() calls in favor of explicit annotations is better. | | #endif /* GDB_VFORK_H */ -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I215683952dec75379ea0a259e79c8dafbae210b9 Gerrit-Change-Number: 746 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-Reviewer: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Thu, 12 Dec 2019 17:22:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Pedro Alves Gerrit-MessageType: comment